[no subject]
>
>
> 2.
> The latest documentation is not online yet because it is not yet in a
> tarball, so I can't link to it, but I've built it locally.
>
> I still can't see anything in the gda_connection_update_meta_store() (or
> anything linked from there) about whether or not we should use
> gda_sql_identifier_add_quotes() for the "table_name" value in
> GdaMataContext::column_values.
>
> The "Update the meta data about a table" section doesn't use
> gda_sql_identifier_add_quotes(), though we now seem to need to use it in
> libgdamm. Note that that section mentions a "Get information" section,
> but there is no link.
>
> 3.
> In fact, I don't see any link from GdaMetaContext to a description of
> possible values for the GdaMetaContext field structs, though the
> gda_connection_update_meta_store() documentation mentios "_tables" and
> "_columns" as possible values for GdaMetaContext::table_name.
>
> The "database structure" section provides some hints, but the
> documentation should explain how that maps to GdaMetaContext."
>
Sorry I've been so long to answer, but I've been busy fixing the SQL
identifiers mess (there are so many differences between databases in
details...)
Anyway, I've just pushed in git LIBGDA_4.0 branch, some fixes in the
gda_sql_identifier_quote() function which you can use in Glom, along with a
test case (which I'll soon add to the NR tests directory), attached (for the
PostgreSQL and MySQL you need to create an empty "testcase" database).
Basically, you have an SQL Id (presumably entered by the user), and use
gda_sql_identifier_quote(id,...,FALSE,...) to have a valid SQL identifier to
create a database object (for example a table), and use again
gda_sql_identifier_quote(id,...,TRUE,...) with
gda_connection_update_meta_store() or other GdaMetaStore's related
functions. See the test case in the attachment.
I'll apply the modifications to the master branch and fix all the
documentation which needs to be fixed ASAP.
Regards,
Vivien
>
>
--001636418965966eb1046ed7fea2
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
<br><br><div class=3D"gmail_quote">2009/7/13 Murray Cumming <span dir=3D"lt=
r"><<a href=3D"mailto:murrayc murrayc com" target=3D"_blank">murrayc mur=
rayc.com</a>></span><br><blockquote class=3D"gmail_quote" style=3D"borde=
r-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-le=
ft: 1ex;">
<div>On Sun, 2009-07-05 at 19:20 +0200, Murray Cumming wrote:<br>
> On Sun, 2009-07-05 at 17:55 +0200, Vivien Malerba wrote:<br>
> > You won't be able to have at the same time a database abstrac=
tion<br>
> > layer and use user input without any validation. For example if y=
ou<br>
> > the user has a MyTable table name, then to use this table you _wi=
ll_<br>
> > at some point have to check if you need quotes or not yourself.<b=
r>
><br>
> I always use quotes. I don't need to check.<br>
<br>
</div><div>Vivien wrote:<br>
> Anyway, I've committed to git master and LIBGDA_4.0 branches ><=
br>
> corrections with documentation which explain the design choices that<b=
r>
> were made.<br>
<br>
</div>Thanks for the recent fixes. Things seem to work now in Glom but I<br=
>
wanted to check that we are really doing the right thing. I have some<br>
questions.<br>
<br>
1.<br>
You added a section about SQL Identifiers that mentions quotes:<br>
<br>
But I find this surprising, and I doubt that it's true:<br>
<a href=3D"http://git.gnome.org/cgit/libgda/tree/doc/C/libgda-4.0-docs.sgml=
#n465" target=3D"_blank">http://git.gnome.org/cgit/libgda/tree/doc/C/libgda=
-4.0-docs.sgml#n465</a><br>
"<br>
Many people consider that using the quoted syntax should be avoided if<br>
possible because:<br>
- once an SQL identifier has been defined using the quoted syntax, it<br>
must always be used quoted, which is error prone especially if external<br>
tools are used on the database.<br>
"</blockquote><div><br>From my own experience and from what I've g=
athered from other people and from the misc docs and books, this is a kind =
of personnal recommendation I'd do. I added it in the doc to explain th=
at Libgda could not force people to use quotes all the time. I can remove i=
t if you think it's out of topic or is out of Libgda's scope.<br>
=A0</div><blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid =
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
2.<br>
The latest documentation is not online yet because it is not yet in a<br>
tarball, so I can't link to it, but I've built it locally.<br>
<br>
I still can't see anything in the gda_connection_update_meta_store() (o=
r<br>
anything linked from there) about whether or not we should use<br>
gda_sql_identifier_add_quotes() for the "table_name" value in<br>
GdaMataContext::column_values.<br>
<br>
The "Update the meta data about a table" section doesn't use<=
br>
gda_sql_identifier_add_quotes(), though we now seem to need to use it in<br=
>
libgdamm. Note that that section mentions a "Get information" sec=
tion,<br>
but there is no link.<br>
<br>
3.<br>
In fact, I don't see any link from GdaMetaContext to a description of<b=
r>
possible values for the GdaMetaContext field structs, though the<br>
gda_connection_update_meta_store() documentation mentios "_tables"=
; and<br>
"_columns" as possible values for GdaMetaContext::table_name.<br>
<br>
The "database structure" section provides some hints, but the<br>
documentation should explain how that maps to GdaMetaContext."<br>
</blockquote><div><br>Sorry I've been so long to answer, but I've b=
een busy fixing the SQL identifiers mess (there are so many differences bet=
ween databases in details...)<br>Anyway, I've just pushed in git LIBGDA=
_4.0 branch, some fixes in the gda_sql_identifier_quote() function which yo=
u can use in Glom, along with a test case (which I'll soon add to the N=
R tests directory), attached (for the PostgreSQL and MySQL you need to crea=
te an empty "testcase" database).<br>
<br>Basically, you have an SQL Id (presumably entered by the user), and use=
gda_sql_identifier_quote(id,...,FALSE,...) to have a valid SQL identifier =
to create a database object (for example a table), and use again gda_sql_id=
entifier_quote(id,...,TRUE,...) with gda_connection_update_meta_store() or =
other GdaMetaStore's related functions. See the test case in the attach=
ment.<br>
<br>I'll apply the modifications to the master branch and fix all the d=
ocumentation which needs to be fixed ASAP.<br><br>Regards,<br><br>Vivien<br=
><br></div><blockquote class=3D"gmail_quote" style=3D"border-left: 1px soli=
d rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div><br>
<br>
</div></div></blockquote></div><br>
--001636418965966eb1046ed7fea2--
--001636418965966eb9046ed7fea4
Content-Type: application/x-bzip-compressed-tar; name="meta-store-case.tbz"
Content-Disposition: attachment; filename="meta-store-case.tbz"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fx7w63690
QlpoOTFBWSZTWQhcmm0ADdp/hN2wEQB/f///////r////+sAAgAIYA0X3gBXuuy7W3MPuN7vd65J
eimhkUBlRQ1ro6A44NGjQNBoDJiAyNDIAA00yAAAYIACUICamTIKYmm9SZoIAaAGTQAGQA0AANBk
mgkmI8jSZDQNGgAAaAAAAAAAAJNRERTIyaTaTTRo0PKHqAaAAAAAAB5CPUBFIhU3poKek9TyZNJo
emoNADIaNA00A0AGgAAIlCBGgJkAp5JtGlG0yepGT1PUZAADRoAaBtI9TgDf/Xp0q70zcLpgyADV
CIgj9VLgkBrKr8zoEYeS/kvC4DEnKEVCtVatIMoTz0RA0oByJIVCIrFYIxEEViKgoIgoMkYCqoMF
gjFWIiLBVUVBgxikFFGCpBQEYogwQef+vv4w056gFZZGi+IMFThSoswlZoXahtMExYUymHf5yJ1s
GjiqmghgYZQbKMJnBUUKSZVaz53c5f95Nmx2bStqIiykp/Le6GPTUxrwTsqh2GB0/3OWs7ld3vY0
hIiVVDM1pt7Vk2AMQYkNWhggoJrVCIo54G5sDM2SmcyHQ2Z5unrf7bbLd3FqCg9jFjpRqkC9Boax
VNmwvxc+t4m03MDV8Xr5sVv4m8/xrel+wd4d6PEIIe+r3fL3j3yVaI7uG7tzAZkmnLJ1ocygikRi
M6unOfoVZp3KiKMsGz+pkDAqZphdKXBQ4RQaAga4+F4S6Bg1QphvTtqaAqmjQkmvGCoY2pUnR/aE
s680kyUQLJgzP7U4/uDTU0lbIBVc62DWmDjZGVgQYRr1GNfRlYpkGmlYxfnONthAS+F7Cw66YfJ/
P12Mx9b82Wsyl6fDEkimU1HBtopf2Dlp4E0EwW7BypcTCjsON70vqHhdzMTNW9EyCKUBhBQFJMbA
z8qVlpF1GqIpJJBYXEZDFIYdVXC8OOZWraljzFDFHxX/XPGWxhtNN64Szfqbmnfb2qCixTgk3+PH
br/PkkznHeDB+pjreQopioc9VHlFokpio4Vs+Nr5GzSEXbxEqEcJYi9Ltzx6vCCqiogg9Qxi5gLu
8dL0ib+v/eocVUN8bu9oJoWCBr2O79BZJAHpiLUIiJamdtPNoOKrCtRaOZ8cNc/ZNyaaaqVm/22L
nLBMiTkUE4Rqi1Cih0aXKOLkmLQQdisowrq2AMRhLPeXoIxI0T3xB8AxyihHNEA+k2Rd01kDWsCA
veSRSFixOLpY6ngzoqa7h5ismuBDge9zmTjsOeaCnLoNNsMLVdTfYzC5o6sLphjN7eQObO/25mlw
hYJDVWvPTW5lg4l5tE1Dp5rjIX9voMQsNwlpVWtEos8wbT7x56BpmwL9Rjn16q49t0XUdyV9nKfx
eDaP1ZV2q3dAy7sAYPZTfYQ3qQDb1d+70gaQLAkyAg0nBNP4IXl9r0kyg7cqCez62eKIQ80CJp0W
Ng8J4JAxwW4HRaUWJzyv1iqxVqqOu2F9UCIFUUasZY3WWCsTf7YZDBCgM9aATtCt9brl17Q7N5en
fXz+avnU9Ae/89BL8vCoFoFYWISpnMfC5WsJxsNWBqmGuGqSle1vk42PztAB3aKj5Xlzec4hSHMf
6+EDZhLwfM/fmXbtl56aGgXvybAtAEIau0noYwZjiYwwVSFxdggNHEkAJRTYAwxDR+Sv1ZyjytK3
XByv0l6c3H6XM0mJbJ0PQ3FjG89lgMB9mO8vTRoLn3EDcSDJ3bwZhTSFFZRUTjcdNAtBxPYbvqHk
ACRcA/Vp2uAQgnABNj43JyqtRkKnVMPEcBBNtVLDhTUJJNqk1kkbpiZClDSQacMFbMxtdpkklJji
KKdDqUuPvljBO7NMHCYdomm9zOjqOojYcaHuBUwhzmp+f0EJryb7jQ73mTWbN2/BJzjkdOcORjkm
RquMzQFQ+IxOjSAkNM3A61zCGM6IlogbY7GLgbl4PRR+o2a34QlWwd6DcCBl1w2iDPkcqad8Necx
mxNocYZGz7/YUxcTtJQlcH9LxXifR5Rfrtii9iU6+iGLA0lBibJ2YmrZX5pW1P5iTaWYIkL3DFQH
BkhohoAq0cWwlhZdFNNwUrQ+bDJGxhdYdBcXNBKK5NT3b/vwCr2mDgWsNHECqFVyWwEsJTMq9htO
oMBPwCkWEjCIiMQIyJAQggJOIUSENSblTenl3I0B3Os/78XqvJAJEQsqm/YT5MROw0BVHlOdhgXg
edvEi8iHgQSpoaARo9KrO8gbcMuSG+BlBHLOkDukCpHCCZkkg1UpXB+ATMIGYSmSfci2NGhoH7rn
wp6x4sSLDg0/4QgEyzGwuNjDtaUkxGpbiXBe0FdsEkNYD3iQQbF1+IZWXoU4Ye14I5inJA7zNqDx
obOJmPdzcmDcBe0CBQuJu9Gdea3gorE1L2GtMFG84Buy440hjKlJd03S3dWVLllkmYJQhaVIjiMy
BSwLYq9YXPxRC9C8vA/2BybETKxBuvpqst0HLUjyrgbwNDfcxPglADYdxRvlBjFoUvEDM3nIw+tm
c/Q/0Y3oXuAmb8JEddm+Tho6oyyoywEWUbxksmTkGddDZJQSDBsh7yREwYJ9GQmSBznGELxNhpEK
r0RhIx8QSbqOBb3RAPc5jJwYOlojiBipDKh1kweiK4wGBAISEOYfQVA9cDVEpUoB5X3WgYQkNTQa
MYp3d49Nw6LinXrAxeLj1CAcdLlRHKjth6joTJ8u27A7lXrY6wsQCYO8C42Nacuq8Lv7PkE6zgSR
N5EMhANZQXPlht0/RsFGmgQD7fppWagey8e3wwKtQDtGA0CAc2SWZmSE/CzomTKFgJMQQJJw06CK
ZdK7NdYS4ZvJO2bVLW21uFjUINhd6RjG885JZVoQA8BodRt+H29WzxIkCcoWqa5m+aVIXw1WUCZy
ounQoEsS00htvTaZgaBeEDyISMgsgcUKwJwkNwf5FmdyhaWqYtX0BGsFoJgabMCaoCU7RpIEjyIu
lygmWnuRL3EsXCmhgIEkSaXVswROhpRIELTEtfsOCwDE9A0VM9eigbR0ojR9TFSEV7rGgTc7h3BG
VGyeWEiRiJEMDqBJEGjzJTW/I8ycynfki3dTFjGChvJRS7oOYop23gHmiBtd2+HpH3AfYVswnjzS
pgL47UCty6qrsEPAhKOppQjOiboblRBClghSKQqkitBjGJGKRiCQeIQRPSwegdJeY1tDXjLDWnKH
TZI3G4gVK0JbcQUljYOQ6UAx6okIrnrDFfligZEdKcESitHIzDl2xuFgZElDUz80EJKhBQYZCKye
APAy4qnQMNK4gYlnajcQvIBoEA/J0emgWCIwvHJhyboUHmDUchhYOjPFsIVO41FWgaRKhSxYL/je
yoGyAXcz5Im0XUZQ4apCcDBN7SitTAlS6xoHShwahNomtYlSgfDLLJQYt4QgRZCEYsRMx4Q2nir2
viuLrqO9rT0AUtUsuLNgOoKiRCTSm4jZild4WNe86RKroOfafM1vEMnQ0eMougzoNIpAkGDAMXaY
sDbkCeuIMIi7Nqj1KGcEC0F60uRMuQfBS1FOAd4ceycmNyO7A3Rkkd0QDNXFUxAq+oPaGjelmF6R
S6KGHmAh6HsBMQDqYs1gEKfHDshesFD/i7kinChIBC5NNoA=
--001636418965966eb9046ed7fea4--
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
