Re: [gnome-db] Memory leaks in V4

["Vivien Malerba" <vmalerba gmail com>]

2008/5/18 Phil Longstaff <plongstaff rogers com>:
> The attached patch fixes 2 leaks in the V4 branch.  The first is a path
> which is built but not freed.  The second is the meta_store, which can
> be created but is not unref'ed when the connection is deleted.
>
> Phil
>
> Index: gda-server-operation.c
> ===================================================================
> --- gda-server-operation.c      (revision 3149)
> +++ gda-server-operation.c      (working copy)
> @@ -2028,6 +2028,7 @@
>                }
>        }
>
> +       g_free (path);
>        g_free (extension);
>        g_free (colname);
>        return allok;
> Index: gda-connection.c
> ===================================================================
> --- gda-connection.c    (revision 3149)
> +++ gda-connection.c    (working copy)
> @@ -243,6 +243,11 @@
>                cnc->priv->trans_status = NULL;
>        }
>
> +       if (cnc->priv->meta_store != NULL) {
> +               g_object_unref(cnc->priv->meta_store);
> +               cnc->priv->meta_store = NULL;
> +       }
> +
>        /* chain to parent class */
>        parent_class->dispose (object);
>  }
>
> _______________________________________________
> gnome-db-list mailing list
> gnome-db-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-db-list
>
>

Patch applied regarding gda-connection.c (the mem leak in
GdaServerOperation has already been fixed).

Thanks,

Vivien