Re: [gnome-db] Little API problems

[Vivien Malerba <vmalerba gmail com>]

2005/9/12, Murray Cumming <murrayc murrayc com>:
> I've noticed some things while wrapping the new libgda API:
> 
> GdaValue:
> - gda_value_set_type(GdaValue*, GType) is declared but not implemented.
> I can't imagine what it's meant to do. Maybe it's meant to take a
> GdaValueType instead of a GType.

It's not supposed to be there, I'm removing that declaration.

> - gda_value_get_binary() returns a GdaBinary* which contains data and a
> size, but the function also has a size output parameter.
> - gda_value_set_binary() takes a gconstpointer of data, though
> get_binary() returns a GdaBinary.

Corrected to be more coherent with the rest of the API.

> 
> GdaColumnIndex:
> - This is a reference-counted object, but it also has a
>   gda_column_index_free() function. When would/could this be
>   used? I'm pretty sure that it should be removed. It does a
>   g_free() instead of a g_object_unref().

Done, I've removed it as it was a bad idea to have such a harmfull function!

Thanks,

Vivien

PS: it's not yet in CVS.