Re: [gnome-db] GnomeDbForm



On Thu, 2003-11-06 at 01:08, Laurent Sansonetti wrote:
> On Mon, 2003-11-03 at 22:08, Rodrigo Moya wrote:
> > > > Currently and AFAIK, the following classes are missing GLib types:
> > > > 
> > > >  - GdaCommand;
> > > >  - GdaFieldAttributes;
> > > >  - GdaParameter;
> > > >  - GdaParameterList; 
> > > >  - GdaQuarkList;
> > > >  - GdaRow;
> > > >  - GdaValue.
> > > > 
> > > 
> > > Any comments on this?
> > > 
> > > I would really like to see GLib types for these classes, so I can work 
> > > on this, if it's approuved ;)
> > > 
> > oh, yes, of course, it's approved, I was just waiting to have a bit of
> > time to do it, so if you want to do it, please go ahead.
> 
> OK, here is a first patch, which should work.
> 
> Unfortunately my Ruby/Libgda test suite is currently broken, so I
> couldn't test the patch deeper.  But I did small tests and everything
> ran fine.
> 
> With this patch, I removed all gboxed code from the Ruby binding.  So
> cool ;-)
> 
looks ok, except for:

+GType
+gda_command_get_type (void)
+{
+       static GType our_type;

here it misses the initialization.

Please fix that and commit, both to HEAD and the 1.0 branch.

Thanks




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]