Re: [gnome-db] updatable data models: first try

[Rodrigo Moya <rodrigo gnome-db org>]

On Tue, 2003-12-02 at 20:54, Laurent Sansonetti wrote:
> Hi all,
> 
> I just worked a few minutes on what rodrigo, paisa and I discussed about
> the design of updatable data models in libgda, and here is a first patch
> (interface only):
> 
>       * Renamed some methods:
> 
>         gda_data_model_is_editable -> gda_data_model_is_updatable ;
>         gda_data_model_begin_edit -> gda_data_model_begin_update ;
>         gda_data_model_cancel_edit -> gda_data_model_cancel_update ;
>         gda_data_model_end_edit -> gda_data_model_end_update ;
>         gda_data_model_is_editing -> gda_data_model_is_updated.
> 
this should be is_updating, not is_updated. We could add a function,
gda_data_model_has_changed, if you want, so that we can know at any time
if a data model has changed.

>       * Renamed some signals:
> 
>         "begin_edit" -> "begin_update" ;
>         "cancel_edit" -> "cancel_update" ;
>         "end_edit" -> "end_update".

>       * Added some methods:
> 
>         gboolean gda_data_model_append_column (GdaDataModel *model,  
>         GdaFieldAttributes *col) ;
>         gboolean gda_data_model_update_column (GdaDataModel *model, 
>         const GdaFieldAttributes *col) ;
>         gboolean gda_data_model_remove_column (GdaDataModel *model, 
>         const GdaFieldAttributes *col).
> 
>       * Added some signals:
> 
>         "column_inserted" ;
>         "column_updated" ;
>         "column_removed".
> 
> Please tell me what you think about this.
> 
it looks great to me, apart from the is_updating/is_updated thing
mentioned above.

Fix that and commit, please.

cheers