Re: [gnome-db] Removed GdaRecordset from postgres

[Rodrigo Moya <rodrigo gnome-db org>]

On Wed, 2002-05-08 at 18:10, Gonzalo Paniagua Javier wrote:
> * [ Rodrigo Moya <rodrigo gnome-db org>
> * Wed, 08 May 2002 15:08:56 +0200 ]
> > > 	Only a couple of functions hanging around:
> > > 	gda_recordset_get_command_type and _text.
> > > 
> > heh, good point. This could make us cancel the removal of GdaRecordset.
> > Could you please do a grep and see where those functions are used?
> > 
> 
> 	Here it is:
> 
> ./libgda/gda-recordset.c:286: * gda_recordset_get_command_text
> ./libgda/gda-recordset.c:294:gda_recordset_get_command_text (GdaRecordset *recset)
> ./libgda/gda-recordset.c:315: * gda_recordset_get_command_type
> ./libgda/gda-recordset.c:323:gda_recordset_get_command_type (GdaRecordset *recset)
> ./testing/models.c:79:	cmd_type = gda_recordset_get_command_type (GDA_DATA_MODEL (model));
> ./testing/models.c:81:	cmd_text = gda_recordset_get_command_text (GDA_DATA_MODEL (model));
> 
heh, not much use. So I think it's safe to remove it (what about
libgnomedb and gnome-db?). Or even better, just let's move those
functions to the GdaDataModel class, since it seems to make sense to
have a command associated with a data model, right?

So, I'd remove those calls in GdaRecordset, and move them to the
GdaDataModel class. Do you agree?

cheers