BonoboPropertyControl leak [Patch]



Hi Michael,

the atached patch fixes a reference counting problem with
BonoboPropertyControl. In fact it was one of the reasons why the
eog-image-viewer didn't shut down properly.

May I commit?

Regards,

   Jens

-- 
"Wer die Freiheit aufgibt, um Sicherheit zu gewinnen, wird am Ende beides
verlieren." -- Benjamin Franklin
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/libbonoboui/ChangeLog,v
retrieving revision 1.256
diff -u -p -r1.256 ChangeLog
--- ChangeLog	2002/01/29 11:20:00	1.256
+++ ChangeLog	2002/01/30 20:59:22
@@ -1,3 +1,9 @@
+2002-01-30  Jens Finke <jens triq net>
+
+	* bonobo/bonobo-property-control.c (bonobo_property_control_new):
+	Don't call bonobo_property_control_new_full here but the construct
+	function.
+
 2002-01-29  Michael Meeks  <michael ximian com>
 
 	* Version 1.110.0
Index: bonobo/bonobo-property-control.c
===================================================================
RCS file: /cvs/gnome/libbonoboui/bonobo/bonobo-property-control.c,v
retrieving revision 1.15
diff -u -p -r1.15 bonobo-property-control.c
--- bonobo/bonobo-property-control.c	2001/12/30 17:51:50	1.15
+++ bonobo/bonobo-property-control.c	2002/01/30 20:59:22
@@ -251,8 +251,8 @@ bonobo_property_control_new (BonoboPrope
 
 	event_source = bonobo_event_source_new ();
 
-	return bonobo_property_control_new_full (
-		get_fn, num_pages, event_source, closure);
+	return bonobo_property_control_construct (
+		property_control, event_source, get_fn, num_pages, closure);
 }
 
 /**


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]