Re: BonoboUnknown & G_SIGNAL_TYPE_STATIC_SCOPE

[Jens Finke <jens triq net>]

Hi Michael,

On 2 Jan 2002, Michael Meeks wrote:
> 	The patch looks fine in fact; thanks for that. The Static scope flag is
> to stop the thing being copied all the time - causing costly remote ref
> / unref behavior.
>
> 	Can you commit ?

Additionally to the return value type changes, what about the struct
offset? Shouldn't it be set like this?:

@@ -148,10 +148,10 @@ bonobo_item_container_class_init (Bonobo
                g_signal_new  ("get_object",
                               G_TYPE_FROM_CLASS (object_class),
                               G_SIGNAL_RUN_LAST,
-                              0,
+                              G_STRUCT_OFFSET (BonoboItemContainerClass, get_object),
                               NULL, NULL,
                               bonobo_marshal_BOXED__STRING_BOOLEAN_BOXED,
-                              BONOBO_TYPE_UNKNOWN,
+                              bonobo_unknown_get_type (),
                               3,
                               BONOBO_TYPE_STRING,
                               G_TYPE_BOOLEAN,


Regards,

   Jens

-- 
"Wer die Freiheit aufgibt, um Sicherheit zu gewinnen, wird am Ende beides
verlieren." -- Benjamin Franklin