Re: Removing _construct functions when fixing _new() functions.



Jody asked me to resend this:

On Mon, 2002-04-15 at 16:08, Murray Cumming wrote:
> I have 3 patches here
> http://bugzilla.gnome.org/show_bug.cgi?id=77225
> to make libbonoboui's various widgets' *_new() functions into mere
> convenience wrappers for g_object_new(). This is achieved by adding
> properties. That's what's they're supposed to be, for the sake of
> language bindings and glade.
> 
> While doing this I've removed the old *_construct() functions. They were
> the GTK1.2 way to solve this problem.
> 
> Officially, this breaks API, but only language bindings (not many for
> libbonoboui yet) and glade (doesn't seem to affect it yet) are going to
> notice, and they should stop using *_construct() anyway. It doesn't make
> much difference, but when *_construct() are removed it makes it easier
> to see that libbonoboui does things properly.

Note that I have since discovered that gnome-db uses one of the
_construct functions to create a derived widget, but that was only as a
workaround for the problem that I've fixed. That's easily changed, and
the rest of GNOME2 builds fine without these functions.

Michael has already said in his previous email that this type of cleanup
is acceptable at this stage of libbonoboui's API maturity.

-- 
Murray Cumming
murrayc usa net
www.murrayc.com




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]