Re: bonobo toolbar separator patch

[John Sullivan <sullivan eazel com>]

on 3/20/00 2:01 AM, Nat Friedman at nat@helixcode.com wrote:

>> By the way, should that toolbar_item_widget != NULL test be an assert
>> instead of a test?
> 
> Can we think of a time we might validly insert a NULL widget into the
> hash table?  It depends on how we handle the separators, I guess.  If
> we just don't stick anything into the hash table for them (as your
> patches indicate), then yes, it should be an assert.  I can't think of
> any other situation which might lead us to stuff a NULL widget in
> there, though.

I suppose there might be another way to fix the separator issue by inserting
a NULL widget. The NULL widget could be the stand-in for a separator. That
might allow us to remove the separator later, which is currently impossible.

I won't change the test to an assertion at this time, but I'll check in my
other changes. There's a FIXME at the point of separator creation that notes
that the separator can't be removed.

John