Re: bonobo toolbar separator patch

[Nat Friedman <nat helixcode com>]

John Sullivan <sullivan@eazel.com> writes:

> The bug is that "found" isn't respected by the g_free (orig_key) line.

The fix looks good.

> By the way, should that toolbar_item_widget != NULL test be an assert
> instead of a test?

Can we think of a time we might validly insert a NULL widget into the
hash table?  It depends on how we handle the separators, I guess.  If
we just don't stick anything into the hash table for them (as your
patches indicate), then yes, it should be an assert.  I can't think of
any other situation which might lead us to stuff a NULL widget in
there, though.

Nat