Re: Tiny patch for bonobo_ui_handler_menu_get_callback
- From: "John Sullivan" <sullivan eazel com>
- To: Michael Meeks <mmeeks gnu org>,Michael Meeks <michael helixcode com>
- Cc: <gnome-components-list gnome org>
- Subject: Re: Tiny patch for bonobo_ui_handler_menu_get_callback
- Date: Sun, 18 Jun 2000 17:45:47 -0700
Hi Michael,
Unfortunately my patch was committed before I got your response. I'll go
tweak it to match Bonobo style, which differs in a few ways from the
Nautilus style I'm used to.
John
on 6/16/00 8:19 PM, Michael Meeks at michael@helixcode.com wrote:
>
> Hi John,
>
> The substance of the patch is great. I consulted the style police
> on a few issues; and they say: perhaps the cut&paste killed the 8 stop tab
> in my viewer, also bonobo doesn't use redundant brackets all over the shop
> so please remove them, also, we use
>
> g_return_if_fail (a != NULL);
>
> But after preconditions use:
>
> if (a)
> *a = foo;
>
> Apart from that; excellent.
>
> Thanks,
>
> Michael.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]