Re: Tiny patch for bonobo_ui_handler_menu_get_callback

Hi John,

	The substance of the patch is great. I consulted the style police
on a few issues; and they say: perhaps the cut&paste killed the 8 stop tab
in my viewer, also bonobo doesn't use redundant brackets all over the shop
so please remove them, also, we use

	g_return_if_fail (a != NULL);

But after preconditions use:

	if (a)
		*a = foo;

	Apart from that; excellent.



--  <><, Pseudo Engineer, itinerant idiot

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]