Re: Tiny patch for bonobo_ui_handler_menu_get_callback
- From: Michael Meeks <michael helixcode com>
- To: John Sullivan <sullivan eazel com>
- Cc: gnome-components-list gnome org
- Subject: Re: Tiny patch for bonobo_ui_handler_menu_get_callback
- Date: Fri, 16 Jun 2000 23:19:52 -0400 (EDT)
Hi John,
The substance of the patch is great. I consulted the style police
on a few issues; and they say: perhaps the cut&paste killed the 8 stop tab
in my viewer, also bonobo doesn't use redundant brackets all over the shop
so please remove them, also, we use
g_return_if_fail (a != NULL);
But after preconditions use:
if (a)
*a = foo;
Apart from that; excellent.
Thanks,
Michael.
--
mmeeks@gnu.org <><, Pseudo Engineer, itinerant idiot
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]