Re: Reduce autoconf requirement

[Pascal de Bruijn <pmjdebruijn pcode nl>]

On Mon, Feb 8, 2010 at 11:23 PM, Andrew Lutomirski <amluto gmail com> wrote:
> Hi all-
>
> For kicks, I just grabbed gnome-color-manager out of git, built it,
> and ran it on KDE4 on Fedora 12.  (why not?)  It seems to work (I
> haven't tested its Argyll integration yet.)
>
> To make it build, though, I had to decrease the autoconf required
> version, like this:
>
> diff --git a/configure.ac b/configure.ac
> index bf4e31f..d4f422b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,4 +1,4 @@
> -AC_PREREQ(2.65)
> +AC_PREREQ(2.63)
>
>  AC_INIT([gnome-color-manager],[2.29.4],[http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-color-manager])
>  AC_CONFIG_SRCDIR(src)
>
> Is there any reason we require autogen 2.65?  2.63 from F12 seems to
> work just fine.

I apply the attached patch to git to make it work on Ubuntu Karmic.

> shared-color-targets needs the same patch.
>
> As an aside, what's the profile graph on the right?  Is it the
> calibration (VCGT), the gray axis of the profile, or something else?
> (I assume it's not the gray axis -- it doesn't really look like
> xicclu's output.)

If I'm not mistaken those are the TRC's...

VCGT is only relevant for displays...

Regards,
Pascal de Bruijn

diff -Nurpd gnome-color-manager-orig/configure.ac gnome-color-manager-hack/configure.ac
--- gnome-color-manager-orig/configure.ac	2010-02-05 18:26:25.000000000 +0100
+++ gnome-color-manager-hack/configure.ac	2010-02-05 18:28:05.053097230 +0100
@@ -1,9 +1,9 @@
-AC_PREREQ(2.65)
+AC_PREREQ(2.52)
 
-AC_INIT([gnome-color-manager],[2.29.4],[http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-color-manager])
+AC_INIT(gnome-color-manager, 2.29.4)
 AC_CONFIG_SRCDIR(src)
 AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
-AC_CONFIG_HEADERS([config.h])
+AM_CONFIG_HEADER(config.h)
 AC_CONFIG_MACRO_DIR([m4])
 
 # enable nice build output on automake1.11
@@ -11,7 +11,7 @@ m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RU
 
 AC_PROG_CC
 AC_PROG_INSTALL
-LT_INIT
+AM_PROG_LIBTOOL
 AM_PROG_CC_C_O
 IT_PROG_INTLTOOL([0.35.0])
 
@@ -24,13 +24,16 @@ GTK_DOC_CHECK(1.9)
 dnl ---------------------------------------------------------------------------
 dnl - Use strict options (default enabled for devs, disabled in releases)
 dnl ---------------------------------------------------------------------------
+
+dnl if .git directory is present, considering we are working in the repository
 if test -d ".git"; then
 	default_strict=yes
 else
 	default_strict=no
 fi
 
-AC_ARG_ENABLE(strict, AS_HELP_STRING([--enable-strict],[Enable strict compilation options]), enable_strict=$enableval,
+AC_ARG_ENABLE(strict, AC_HELP_STRING([--enable-strict],
+					[Enable strict compilation options]), enable_strict=$enableval,
 					enable_strict=$default_strict)
 if test x$enable_strict != xno; then
 	if test "$GCC" = "yes"; then
@@ -237,7 +240,7 @@ AC_SUBST(GCM_SYSTEM_PROFILES_DIR, "\$(lo
 dnl ---------------------------------------------------------------------------
 dnl - Makefiles, etc.
 dnl ---------------------------------------------------------------------------
-AC_CONFIG_FILES([
+AC_OUTPUT([
 Makefile
 data/Makefile
 data/icons/Makefile
@@ -256,7 +259,6 @@ po/Makefile.in
 rules/Makefile
 src/Makefile
 ])
-AC_OUTPUT
 
 dnl ==========================================================================
 echo "