Re: [gnome-boxes 1/2] Skip 'Preparation' & 'Setup' when going backwards

[Marc-André Lureau <marcandre lureau gmail com>]

On Thu, Nov 3, 2011 at 6:07 PM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> On Thu, Nov 3, 2011 at 7:05 PM, Zeeshan Ali (Khattak)
> <zeeshanak gnome org> wrote:
>> On Thu, Nov 3, 2011 at 6:38 PM, Marc-André Lureau
>> <marcandre lureau gmail com> wrote:
>>>> +        else if (page < this.page &&
>>>> +                 page == Boxes.WizardPage.PREPARATION ||
>>>> +                 page == Boxes.WizardPage.SETUP)
>>>> +            return true;
>>>
>>> Which I translate to if going backward, always skip preparation &
>>> setup. This doesn't seem to be correct, as you may want to change your
>>> username in the Setup step.
>>
>>  True but we are currently skipping Review when going forward so it
>> makes sense to skip this empty step in other direction too.
>
>  Err... I meant 'Setup' of course.

If I follow you reasoning, and you add or remove things temporarily, I
don't see why we shouldn't remove the setup step altogether, and other
useless, non-working things.

Instead, I would prefer to have the page filled with what is expected,
even if it's not used yet by the installer. I thought you already had
ways to tweak the installation to create a user for instance.

regards

-- 
Marc-André Lureau