Re: Buttons and AtkValue

[Bill Haneman <bill haneman ireland sun com>]

Padraig O'Briain wrote:
> 
> My excuse here is that I am following Java. AccessibleAbstractButton implements
> AccessibleValue to set a button to be selected (or not) and get the selected
> state. I propose to follow the same convention for ATK.

This still seems broken to me.

For one thing, it complicates life for the AT since it makes it harder
to detect "range controllers" as opposed to just plain
togglebuttons... a range controller with a range of 0 to 1 and no
intermediate values seems like a degenerate case.  OK, a *truly*
degenerate case would have min==max, we ignore that one ;-)

It also seems totally unnecessary since a combination of get_state and
do_action entirely duplicates the functionality of AtkValue for this
case.  Usually I like to keep consistent with the Java API but this
might be an exception.

-Bill

> My understanding is that "selected" is equivalent to "checked". I think I lied
> in my previous statement about not having an action "toggle". A button has one
> action which is to click the button which is probably the same as toggle.
> 
> Padraig
> 
> >
> >
> > >GtkToggleButton Notes:
> > >The comments on GtkButton and AtkAction interface also apply here; i.e. one
> action on a button. I have
> > >GaelToggleButton implementing AtkValue interface to set the button to
> > >active or
> > >not so I do not have an action "toggle".
> > >
> > >***
> > My understanding of AtkValue is that it is for things which can have a
> > range of values, and that the "checked" state is for objects which only
> > have two states.
> > ***

-- 
--------------
Bill Haneman
Gnome Accessibility / Batik SVG Toolkit
Sun Microsystems Ireland