Re: [g-a-devel] Patch to fix a bunch of compiler warnings in at-spi



man, 09,.01.2006 kl. 13.04 +0000, skrev Bill Haneman:
> Hi Kjartan:
> 
> Thanks for the patch - however I don't think the g_return_val_if_fail() 
> in spi_accessible_new is correct.  The assertions are correct IMO; 
> bypassing them just masks serious problems, making them harder to detect 
> and fix.  Otherwise it looks very helpful, so please commit except for 
> the minor issue above. 
> 
Oh, that was just me trying to figure out the other problem we've
discussed and forgetting to remove it before creating the diff. I'll
remove it and commit the rest.

Cheers
Kjartan





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]