Re: [g-a-devel] Patch to fix a bunch of compiler warnings in at-spi
- From: Bill Haneman <Bill Haneman Sun COM>
- To: Kjartan Maraas <kmaraas broadpark no>
- Cc: gnome-accessibility-devel gnome org
- Subject: Re: [g-a-devel] Patch to fix a bunch of compiler warnings in at-spi
- Date: Mon, 09 Jan 2006 13:04:33 +0000
Hi Kjartan:
Thanks for the patch - however I don't think the g_return_val_if_fail()
in spi_accessible_new is correct. The assertions are correct IMO;
bypassing them just masks serious problems, making them harder to detect
and fix. Otherwise it looks very helpful, so please commit except for
the minor issue above.
Bill
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]