GNOME.org
 

[g-a-devel] Patch to fix a bunch of compiler warnings in at-spi

Patch attached.

Cheers
Kjartan

? depcomp
? gtk-doc.make
? warnings
? libspi/.accessible.c.swp
? login-helper/Accessibility_LoginHelper-common.c
? login-helper/Accessibility_LoginHelper-imodule.c
? login-helper/Accessibility_LoginHelper-skels.c
? login-helper/Accessibility_LoginHelper-stubs.c
? login-helper/Accessibility_LoginHelper.h
? po/stamp-it
? test/event-listener-test
? test/keypad-test
? test/keysynth-test
? test/login-helper-client-test
? test/login-helper-server-test
? test/screen-review-test
? test/stress-test
? test/window-listener-test
Index: configure.in
===================================================================
RCS file: /cvs/gnome/at-spi/configure.in,v
retrieving revision 1.169
diff -u -p -r1.169 configure.in
--- configure.in	29 Dec 2005 06:04:12 -0000	1.169
+++ configure.in	9 Jan 2006 12:56:37 -0000
@@ -202,6 +202,7 @@ AC_SUBST(REBUILD)
 
 AC_OUTPUT([
 Makefile
+po/Makefile.in
 libspi-1.0.pc
 libspi-1.0-uninstalled.pc
 libloginhelper-1.0.pc
Index: cspi/spi_main.c
===================================================================
RCS file: /cvs/gnome/at-spi/cspi/spi_main.c,v
retrieving revision 1.42
diff -u -p -r1.42 spi_main.c
--- cspi/spi_main.c	3 Aug 2004 08:49:53 -0000	1.42
+++ cspi/spi_main.c	9 Jan 2006 12:56:37 -0000
@@ -453,6 +453,7 @@ SPI_nextEvent (SPIBoolean waitForEvent)
   return NULL;
 }
 
+#ifdef PRINT_LEAKS
 static void
 report_leaked_ref (gpointer key, gpointer val, gpointer user_data)
 {
@@ -476,7 +477,7 @@ report_leaked_ref (gpointer key, gpointe
 
   SPI_freeString (name);
 }
-
+#endif
 
 /**
  * SPI_exit:
Index: cspi/spi_streamablecontent.c
===================================================================
RCS file: /cvs/gnome/at-spi/cspi/spi_streamablecontent.c,v
retrieving revision 1.9
diff -u -p -r1.9 spi_streamablecontent.c
--- cspi/spi_streamablecontent.c	2 Nov 2005 18:01:16 -0000	1.9
+++ cspi/spi_streamablecontent.c	9 Jan 2006 12:56:37 -0000
@@ -67,7 +67,6 @@ accessible_bonobo_stream_client_seek (co
 				      Bonobo_Stream_SeekType seek_type,
 				      CORBA_Environment  *opt_ev)
 {
-	Bonobo_StorageInfo *info;
 	CORBA_Environment  *ev, temp_ev;
 	CORBA_long ret_offset;
        
@@ -258,7 +257,6 @@ AccessibleStreamableContent_seek (Access
       stream = cached->stream;
       if (stream != CORBA_OBJECT_NIL)
 	{
-          guint8 *mem;
 	  switch (seek_type) {
 	  case SPI_STREAM_SEEK_SET:
 	    bonobo_seek_type = Bonobo_Stream_SeekSet; 
Index: libspi/application.c
===================================================================
RCS file: /cvs/gnome/at-spi/libspi/application.c,v
retrieving revision 1.26
diff -u -p -r1.26 application.c
--- libspi/application.c	4 Dec 2003 23:07:11 -0000	1.26
+++ libspi/application.c	9 Jan 2006 12:56:37 -0000
@@ -25,6 +25,7 @@
 
 #include <string.h>
 #include <config.h>
+#include <glib.h>
 #include <atk/atkutil.h>
 #include <libspi/application.h>
 #include <locale.h>
@@ -289,6 +290,8 @@ BONOBO_TYPE_FUNC_FULL (SpiApplication,
 SpiApplication *
 spi_application_new (AtkObject *app_root)
 {
+  g_return_val_if_fail (app_root != NULL, NULL);
+
   return SPI_APPLICATION (spi_accessible_construct (
 			  SPI_APPLICATION_TYPE, app_root));
 }
Index: libspi/text.c
===================================================================
RCS file: /cvs/gnome/at-spi/libspi/text.c,v
retrieving revision 1.22
diff -u -p -r1.22 text.c
--- libspi/text.c	1 Dec 2003 17:10:51 -0000	1.22
+++ libspi/text.c	9 Jan 2006 12:56:37 -0000
@@ -313,7 +313,6 @@ impl_getDefaultAttributes (PortableServe
 			   CORBA_Environment *ev)
 {
   AtkAttributeSet *set;
-  gint intstart_offset, intend_offset;
   CORBA_char *rv;
   AtkText *text = get_text_from_servant (servant);
 
Index: login-helper/login-helper.c
===================================================================
RCS file: /cvs/gnome/at-spi/login-helper/login-helper.c,v
retrieving revision 1.2
diff -u -p -r1.2 login-helper.c
--- login-helper/login-helper.c	25 Aug 2005 15:48:25 -0000	1.2
+++ login-helper/login-helper.c	9 Jan 2006 12:56:37 -0000
@@ -34,9 +34,6 @@ static BonoboObjectClass *bonobo_object_
 static void
 login_helper_finalize (GObject *object)
 {
-  LoginHelper *helper = (LoginHelper *) object;
-  CORBA_Environment ev;
-
   (G_OBJECT_CLASS (bonobo_object_parent_class))->finalize (object);
 }
 
@@ -209,7 +206,6 @@ login_helper_class_init (LoginHelperClas
 static void
 login_helper_init (GObject *object)
 {
-    LoginHelper *helper = LOGIN_HELPER (object);
 }
 
 BONOBO_TYPE_FUNC_FULL (LoginHelper,
Index: registryd/deviceeventcontroller.c
===================================================================
RCS file: /cvs/gnome/at-spi/registryd/deviceeventcontroller.c,v
retrieving revision 1.88
diff -u -p -r1.88 deviceeventcontroller.c
--- registryd/deviceeventcontroller.c	2 Nov 2005 18:01:23 -0000	1.88
+++ registryd/deviceeventcontroller.c	9 Jan 2006 12:56:37 -0000
@@ -221,7 +221,6 @@ spi_dec_replace_map_keysym (DEController
   if (desc && desc->map)
     {
       gint offset = desc->map->key_sym_map[keycode].offset;
-      long old_sym = desc->map->syms[offset]; 
       desc->map->syms[offset] = keysym; 
     }
   else
@@ -617,7 +616,9 @@ spi_dec_ungrab_mouse (gpointer data)
 static void
 spi_dec_init_mouse_listener (SpiRegistry *registry)
 {
+#ifdef GRAB_BUTTON
   Display *display = spi_get_display ();
+#endif
   g_timeout_add (100, spi_dec_poll_mouse_idle, registry);
 
 #ifdef GRAB_BUTTON
@@ -2519,7 +2520,6 @@ is_key_released (KeyCode code)
 {
   char keys[32];
   int down;
-  int i;
 
   XQueryKeymap (spi_get_display (), keys);
   down = BIT (keys, code);
Index: test/event-listener-test.c
===================================================================
RCS file: /cvs/gnome/at-spi/test/event-listener-test.c,v
retrieving revision 1.23
diff -u -p -r1.23 event-listener-test.c
--- test/event-listener-test.c	10 May 2005 17:13:53 -0000	1.23
+++ test/event-listener-test.c	9 Jan 2006 12:56:37 -0000
@@ -87,14 +87,7 @@ usage_and_exit( void )
 int
 main (int argc, char **argv)
 {
-  int i, j, c;
-  int n_desktops;
-  int n_apps;
-  char *s;
-  gdouble elapsed_time;
-  Accessible *desktop;
-  Accessible *application;
-  const char *modules;
+  int c;
 
   /* Parse Command-line */
   if ( argc > 1 ) {
@@ -337,7 +330,7 @@ report_event (const AccessibleEvent *eve
   }
   ++count;
   if ((count % 100) == 0) {
-	  g_print ("%d events received, %f events/sec\n",
+	  g_print ("%ld events received, %f events/sec\n",
 		   count,
 		   count/g_timer_elapsed(timer, NULL));
   }
@@ -356,7 +349,7 @@ report_caret_event (const AccessibleEven
 				  SPI_TEXT_BOUNDARY_SENTENCE_START,
 				  &start, &end);
   fprintf (stderr, 
-	   "caret event from %s %s: offset %d, SENTENCE_START offsets start=%d, end=%d\n", 
+	   "caret event from %s %s: offset %ld, SENTENCE_START offsets start=%ld, end=%ld\n", 
 	   event->type, s, offset, start, end);
   AccessibleText_getTextAtOffset (text, offset, 
 				  SPI_TEXT_BOUNDARY_SENTENCE_END,
@@ -368,7 +361,7 @@ report_caret_event (const AccessibleEven
 				  SPI_TEXT_BOUNDARY_LINE_END,
 				  &line_end_begin, &line_end_end);
   fprintf (stderr, 
-	   "SENTENCE_END: %d - %d; LINE_START: %d - %d; LINE_END: %d - %d\n", 
+	   "SENTENCE_END: %ld - %ld; LINE_START: %ld - %ld; LINE_END: %ld - %ld\n", 
 	   start, end, line_start_begin, line_start_end,
 	   line_end_begin, line_end_end);
 
@@ -379,7 +372,7 @@ report_caret_event (const AccessibleEven
 				  SPI_TEXT_BOUNDARY_WORD_END,
 				  &line_end_begin, &line_end_end);
   fprintf (stderr, 
-	   "WORD_START: %d - %d; WORD_END: %d - %d\n", 
+	   "WORD_START: %ld - %ld; WORD_END: %ld - %ld\n", 
 	   line_start_begin, line_start_end,
 	   line_end_begin, line_end_end);
 
@@ -390,7 +383,7 @@ void
 report_detail_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   if (s) SPI_freeString (s);
 }
@@ -399,7 +392,7 @@ void
 report_detail1_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld\n", event->type, s,
 	   event->detail1);
   if (s) SPI_freeString (s);
 }
@@ -410,7 +403,7 @@ report_bounds_event (const AccessibleEve
   char *s = Accessible_getName (event->source);
   SPIRect *bounds = AccessibleBoundsChangedEvent_getNewBounds (event);
   if (!bounds) fprintf (stderr, "bounds-changed event with no bounds?\n");
-  fprintf (stderr, "(bounds-changed) %s %s %d,%d - %d,%d\n", event->type, s,
+  fprintf (stderr, "(bounds-changed) %s %s %ld,%ld - %ld,%ld\n", event->type, s,
 	   bounds->x, bounds->y, bounds->x + bounds->width, bounds->y + bounds->height);
   SPI_freeRect (bounds);
   if (s) SPI_freeString (s);
@@ -420,7 +413,7 @@ void
 report_text_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleTextChangedEvent_getChangeString (event);
@@ -432,7 +425,7 @@ void
 report_text_selection_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleTextSelectionChangedEvent_getSelectionString (event);
@@ -449,7 +442,7 @@ report_active_descendant_changed_event (
 
   ao = AccessibleActiveDescendantChangedEvent_getActiveDescendant (event);
   s1 = Accessible_getName (ao);
-  fprintf (stderr, "(detail) %s parent: %s child: %s %d %d\n", event->type, 
+  fprintf (stderr, "(detail) %s parent: %s child: %s %ld %ld\n", event->type, 
            s ? s : "<null>", s1 ? s1 : "<null>",
 	   event->detail1, event->detail2);
   SPI_freeString (s);
@@ -467,7 +460,7 @@ report_children_changed_event (const Acc
   if (ao) s1 = Accessible_getName (ao);
   s2 = Accessible_getRoleName (event->source);
   if (ao) s3 = Accessible_getRoleName (ao);
-  fprintf (stderr, "(detail) %s parent: %s [%s] child: %s [%s] %d %d\n", 
+  fprintf (stderr, "(detail) %s parent: %s [%s] child: %s [%s] %ld %ld\n", 
            event->type, 
            s ? s : "<null>", 
 	   s2,
@@ -485,7 +478,7 @@ void
 report_name_changed_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleNameChangedEvent_getNameString (event);
@@ -497,7 +490,7 @@ void
 report_description_changed_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleDescriptionChangedEvent_getDescriptionString (event);
@@ -514,7 +507,7 @@ report_parent_changed_event (const Acces
 
   ao = AccessibleParentChangedEvent_getParentAccessible (event);
   s1 = Accessible_getName (ao);
-  fprintf (stderr, "(detail) %s parent: %s child: %s %d %d\n", event->type, 
+  fprintf (stderr, "(detail) %s parent: %s child: %s %ld %ld\n", event->type, 
            s ? s : "<null>", s1 ? s1 : "<null>",
 	   event->detail1, event->detail2);
   SPI_freeString (s);
@@ -526,7 +519,7 @@ void
 report_window_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleWindowEvent_getTitleString (event);
@@ -543,7 +536,7 @@ report_table_summary_event (const Access
 
   ao = AccessibleTableSummaryChangedEvent_getSummaryAccessible (event);
   s1 = Accessible_getName (ao);
-  fprintf (stderr, "(detail) %s parent: %s child: %s %d %d\n", event->type, 
+  fprintf (stderr, "(detail) %s parent: %s child: %s %ld %ld\n", event->type, 
            s ? s : "<null>", s1 ? s1 : "<null>",
 	   event->detail1, event->detail2);
   SPI_freeString (s);
@@ -560,7 +553,7 @@ report_table_header_event (const Accessi
 
   ao = AccessibleTableHeaderChangedEvent_getHeaderAccessible (event);
   s1 = Accessible_getName (ao);
-  fprintf (stderr, "(detail) %s parent: %s child: %s %d %d\n", event->type, 
+  fprintf (stderr, "(detail) %s parent: %s child: %s %ld %ld\n", event->type, 
            s ? s : "<null>", s1 ? s1 : "<null>",
 	   event->detail1, event->detail2);
   SPI_freeString (s);
@@ -572,7 +565,7 @@ void
 report_table_caption_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleTableCaptionChangedEvent_getCaptionString (event);
@@ -584,7 +577,7 @@ void
 report_table_row_description_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleTableRowDescriptionChangedEvent_getDescriptionString (event);
@@ -596,7 +589,7 @@ void
 report_table_column_description_event (const AccessibleEvent *event, void *user_data)
 {
   char *s = Accessible_getName (event->source);
-  fprintf (stderr, "(detail) %s %s %d %d\n", event->type, s,
+  fprintf (stderr, "(detail) %s %s %ld %ld\n", event->type, s,
 	   event->detail1, event->detail2);
   SPI_freeString (s);
   s = AccessibleTableColumnDescriptionChangedEvent_getDescriptionString (event);
@@ -622,7 +615,7 @@ timing_test_event (const AccessibleEvent
 	if (count == 0) g_timer_start (timer);
 	++count;
 	if ((count % 500) == 0) {
-		g_print ("%d events received, %f events/sec\n",
+		g_print ("%ld events received, %f events/sec\n",
 			 count,
 			 count/g_timer_elapsed(timer, NULL));
 	}
Index: test/key-listener-test.c
===================================================================
RCS file: /cvs/gnome/at-spi/test/key-listener-test.c,v
retrieving revision 1.10
diff -u -p -r1.10 key-listener-test.c
--- test/key-listener-test.c	27 May 2004 17:39:19 -0000	1.10
+++ test/key-listener-test.c	9 Jan 2006 12:56:37 -0000
@@ -195,7 +195,7 @@ report_tab_key_event (const AccessibleKe
 static SPIBoolean
 report_all_key_event (const AccessibleKeystroke *key, void *user_data)
 {
-  fprintf(stderr, "(%d)", key->keyID);
+  fprintf(stderr, "(%ld)", key->keyID);
   return FALSE;
 }
 
Index: test/keypad-test.c
===================================================================
RCS file: /cvs/gnome/at-spi/test/keypad-test.c,v
retrieving revision 1.2
diff -u -p -r1.2 keypad-test.c
--- test/keypad-test.c	27 May 2004 17:39:19 -0000	1.2
+++ test/keypad-test.c	9 Jan 2006 12:56:37 -0000
@@ -165,7 +165,7 @@ get_keypad_keycodes (void)
 static void
 print_key_event (const AccessibleKeystroke *key, char *prefix)
 {
-  fprintf (stderr, "%s KeyEvent %s%c [keysym 0x%x] (keycode %d); string=%s; time=%lx\n",
+  fprintf (stderr, "%s KeyEvent %s%c [keysym 0x%ld] (keycode %d); string=%s; time=%lx\n",
 	   prefix,
 	  (key->modifiers & SPI_KEYMASK_ALT)?"Alt-":"",
 	  ((key->modifiers & SPI_KEYMASK_SHIFT)^(key->modifiers & SPI_KEYMASK_SHIFTLOCK))?
Index: test/login-helper-server-test.c
===================================================================
RCS file: /cvs/gnome/at-spi/test/login-helper-server-test.c,v
retrieving revision 1.5
diff -u -p -r1.5 login-helper-server-test.c
--- test/login-helper-server-test.c	25 Jan 2005 08:58:54 -0000	1.5
+++ test/login-helper-server-test.c	9 Jan 2006 12:56:37 -0000
@@ -1,5 +1,6 @@
 #include <libbonobo.h>
 #include <login-helper/login-helper.h>
+#include <gtk/gtkmain.h>
 #include <gtk/gtkwindow.h>
 #include <gdk/gdkx.h>
 #include <X11/Xatom.h>
@@ -25,7 +26,7 @@ int
 main (int argc, char **argv)
 {
 	int          ret;
-	char        *obj_id, *display_name;
+	char        *obj_id;
 	BonoboObject *helper;
 	
 	if (!bonobo_init (&argc, argv))
Index: test/screen-review-test.c
===================================================================
RCS file: /cvs/gnome/at-spi/test/screen-review-test.c,v
retrieving revision 1.14
diff -u -p -r1.14 screen-review-test.c
--- test/screen-review-test.c	2 Nov 2005 18:01:24 -0000	1.14
+++ test/screen-review-test.c	9 Jan 2006 12:56:37 -0000
@@ -90,7 +90,6 @@
 
 static void report_screen_review_line  (const AccessibleEvent *event, void *user_data);
 
-static gint n_elements_traversed = 0;
 static AccessibleEventListener *mouseclick_listener;
 
 typedef struct _BoundaryRect {
@@ -123,16 +122,6 @@ static gboolean isJava = FALSE;
 int
 main (int argc, char **argv)
 {
-  int i, j;
-  int n_desktops;
-  int n_apps;
-  char *s;
-  GTimer *timer;
-  gdouble elapsed_time;
-  Accessible *desktop;
-  Accessible *application;
-  const char *modules;
-
   SPI_init ();
 
   mouseclick_listener = SPI_createAccessibleEventListener (
@@ -312,7 +301,7 @@ text_chunk_split_insert (GList *chunk_li
 static void
 print_chunk_debug (TextChunk *chunk, char *opname, GList *prev, GList *next)
 {
-	fprintf (stderr, "%sing chunk %s between %s and %s; %d-%d\n",
+	fprintf (stderr, "%sing chunk %s between %s and %s; %ld-%ld\n",
 		 opname,
 		 chunk->string,
 		 (prev ? ((TextChunk *) prev->data)->string : "<null>"),
@@ -459,7 +448,6 @@ review_buffer_get_text_chunk (ScreenRevi
 	AccessibleText *text = NULL;
 	AccessibleRole role;
 	TextChunk *text_chunk;
-	BoundaryRect start_char_bounds, end_char_bounds;
 	char *s = NULL;
 	int offset;
 	long start, end;
@@ -585,13 +573,14 @@ review_buffer_get_text_chunk (ScreenRevi
 	return text_chunk;
 }
 
+#ifdef CHUNK_LIST_DEBUG
 static void
 debug_chunk_list (GList *iter)
 {
 	TextChunk *chunk;
 	while (iter) {
 		chunk = (TextChunk *)iter->data;
-		fprintf (stderr, "Chunk %s, clip %d-%d, text %d-%d\n",
+		fprintf (stderr, "Chunk %s, clip %ld-%ld, text %ld-%ld\n",
 			 chunk->string,
 			 chunk->clip_bounds.x,
 			 chunk->clip_bounds.x + chunk->clip_bounds.width,
@@ -600,6 +589,7 @@ debug_chunk_list (GList *iter)
 		iter = iter->next;
 	}
 }
+#endif
 
 static void
 clip_into_buffers (Accessible *accessible,  BoundaryRect* parentClipBounds[],
@@ -745,7 +735,7 @@ string_guess_clip (TextChunk *chunk)
 			start_offset = len * (chunk->text_bounds.x - b.x) / b.width;
 			end_offset = len * (chunk->text_bounds.x +
 					    chunk->text_bounds.width - b.x) / b.width;
-			fprintf (stderr, "String len %d, clipped to %d-%d\n",
+			fprintf (stderr, "String len %ld, clipped to %ld-%ld\n",
 				 len, start_offset, end_offset);
 			len = end_offset - start_offset;
 			sp = g_utf8_offset_to_pointer (chunk->string, start_offset);
@@ -763,7 +753,6 @@ static char*
 text_chunk_get_clipped_string (TextChunk *chunk)
 {
 	char *s, *string = "";
-	int i;
 	long start = chunk->start_offset, end = chunk->end_offset;
 	long word_start, word_end, range_end;
 	BoundaryRect start_bounds, end_bounds;
@@ -893,7 +882,6 @@ text_chunk_list_to_string (GList *iter)
 	char *s = "";
 	char *string;
 	TextChunk *chunk = NULL;
-	int offset = 0;
 	while (iter) {
 		chunk = (TextChunk *)iter->data;
 		if (chunk) {
@@ -983,14 +971,14 @@ static char *
 get_screen_review_line_at (int x, int y)
 {
   char *string;
-  Accessible *desktop, *app, *toplevel, *child;
+  Accessible *desktop, *app, *toplevel;
   AccessibleComponent *component;
   AccessibleStateSet *states;
   GList *toplevels = NULL, *actives = NULL, *iter;
   ScreenReviewBuffer* reviewBuffers[SPI_LAYER_LAST_DEFINED];
   BoundaryRect* clip_bounds[SPI_LAYER_LAST_DEFINED];
   BoundaryRect toplevel_bounds;
-  int n_apps, n_toplevels, n_children, app_n, toplevel_n, child_n;
+  int n_apps, n_toplevels, app_n, toplevel_n;
   GTimer *timer = g_timer_new ();
   int i;
 
@@ -1045,8 +1033,8 @@ get_screen_review_line_at (int x, int y)
 	  if (Accessible_isComponent (toplevel)) {
   	      /* make sure toplevel is visible and not iconified or shaded */
 	      states = Accessible_getStateSet (toplevel);
-	      if (AccessibleStateSet_contains (states, SPI_STATE_VISIBLE)
-		  && !AccessibleStateSet_contains (states, SPI_STATE_ICONIFIED)
+	      if ((AccessibleStateSet_contains (states, SPI_STATE_VISIBLE)
+		  && (!AccessibleStateSet_contains (states, SPI_STATE_ICONIFIED)))
 		  || isJava) { /* isJava hack! */
 		      component = Accessible_getComponent (toplevel);
 		      AccessibleComponent_getExtents (component,
Index: test/simple-at.c
===================================================================
RCS file: /cvs/gnome/at-spi/test/simple-at.c,v
retrieving revision 1.47
diff -u -p -r1.47 simple-at.c
--- test/simple-at.c	29 Sep 2004 23:44:31 -0000	1.47
+++ test/simple-at.c	9 Jan 2006 12:56:37 -0000
@@ -389,7 +389,7 @@ report_text_event (const AccessibleEvent
       long start, end;
       char *word_text = AccessibleText_getTextAtOffset (text, (long) event->detail1, SPI_TEXT_BOUNDARY_WORD_START, &start, &end);
       char *sentence_text = AccessibleText_getTextAtOffset (text, (long) event->detail1, SPI_TEXT_BOUNDARY_SENTENCE_START, &start, &end);
-      fprintf (stderr, "text changed: word %s; sentence %s at %d",
+      fprintf (stderr, "text changed: word %s; sentence %s at %ld",
 	       (word_text ? word_text : ""),
       	       (sentence_text ? sentence_text : ""),
 	       event->detail1);
Index: test/stress-test.c
===================================================================
RCS file: /cvs/gnome/at-spi/test/stress-test.c,v
retrieving revision 1.6
diff -u -p -r1.6 stress-test.c
--- test/stress-test.c	20 Aug 2004 17:11:42 -0000	1.6
+++ test/stress-test.c	9 Jan 2006 12:56:37 -0000
@@ -43,7 +43,6 @@ main (int argc, char **argv)
 	GObject *object;
 	AtkObject *atko;
 	GTimer *timer;
-	gdouble elapsed_time;
 
 	gtk_init (&argc, &argv);
 	SPI_init ();
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]