Re: [g-a-devel] GAIL: Problem with is_attached_menu_window function



Hi Marcin,

Thank you. I have add comments.

Li

On Tue, 2006-12-12 at 08:43 +0100, Marcin Lyko wrote:
> Hi Li,
> 
> I added the patch to a bug
> http://bugzilla.gnome.org/show_bug.cgi?id=371412
> Is it OK?
> 
> BR,
> Marcin
> 
> > Hi Marcin,
> > 
> > You can fire a bug about this and paste the patch on the bug.
> > 
> > Thanks,
> > Li
> > 
> > On Mon, 2006-12-11 at 17:09 +0100, Marcin Lyko wrote:
> > 
> >>>>>This is *not* the correct solution; if you change
> >>>>>is_attached_menu_window, the attached menu appears at the wrong place in
> >>>>>the at-spi hierarchy.
> >>>>>
> >>>>>So, the problem is not in is_attached_menu_window - the window should
> >>>>>NOT appear there, it should appear elsewhere, as a child of the widget
> >>>>>to which it is attached.
> >>>>>    
> >>>>
> >>>>
> >>>>It seems that the problem is not in Gail. So where should I search a
> >>>>source of the problem if not in Gail? Maybe it is a bug of Gtk+?
> >>>>  
> >>>
> >>>Hi Martin:
> >>>
> >>>I think the bug is still probably in Gail, but not where you originally
> >>>thought.  It's an RFE I suppose; I am not sure whether it should live in
> >>>gailwidget.c or perhaps some other gail file, but an AtkObject for a
> >>>widget that has an attached menu should include the attached menu among
> >>>its children, and that child AtkObject should become VISIBLE and SHOWING
> >>>when it pops up (also with FOCUSSED property at the appropriate place
> >>>within the menu, which is probably already taken care of by the existing
> >>>Gail menu code).
> >>>
> >>>That is - the AtkObject which represents the menu should exist, and be
> >>>created by Gail as it is created now, but instead of being a toplevel
> >>>window, it should be a child of the object to which the menu is attached.
> >>
> >>Hi Bill,
> >>I found some mistakes in gailbutton.c. Problems which I've found were
> >>placed in two functions: gail_button_get_n_children and
> >>gail_button_ref_child. The patch in the attachment resolves all problems
> >>with menus attached to buttons. After adding the attachment, attached
> >>menus exist as children of the buttons.
> >>
> >>Regards,
> >>Marcin
> >>_______________________________________________
> >>Gnome-accessibility-devel mailing list
> >>Gnome-accessibility-devel gnome org
> >>http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel
> > 
> > 
> > 
> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]