Re: [g-a-devel]libspi patch ... take 2

["Padraig O'Briain" <Padraig Obriain Sun COM>]

Michael,

This patch look OK, except for the cast to G_OBJECT in the call to 
spi_accessible_construct(); the second argumene should be an AtkObject*.

Padraig



> 
> Hi Bill,
> 
> 	So this is a far more minimal patch - it doesn't solve some of the
> issues of remote equivalence for CORBA wrapped non AtkObjects but then
> they probably arn't of concern to anyone,
> 
> 	May I commit ?
> 
> 		Michael.
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/at-spi/ChangeLog,v
> retrieving revision 1.176
> diff -u -p -u -r1.176 ChangeLog
> --- ChangeLog	19 Mar 2002 22:31:43 -0000	1.176
> +++ ChangeLog	21 Mar 2002 11:43:05 -0000
> @@ -1,3 +1,9 @@
> +2002-03-21  Michael Meeks  <michael ximian com>
> +
> +	* libspi/application.c (spi_application_new):
> +	use spi_accessible_construct so we use the AtkObject
> +	cache correctly.
> +
>  2002-03-19  Michael Meeks  <michael ximian com>
>  
>  	* registryd/registry.c (desktop_remove_application),
> Index: libspi/application.c
> ===================================================================
> RCS file: /cvs/gnome/at-spi/libspi/application.c,v
> retrieving revision 1.19
> diff -u -p -u -r1.19 application.c
> --- libspi/application.c	18 Dec 2001 13:38:44 -0000	1.19
> +++ libspi/application.c	21 Mar 2002 11:43:05 -0000
> @@ -362,9 +362,6 @@ BONOBO_TYPE_FUNC_FULL (SpiApplication,
>  SpiApplication *
>  spi_application_new (AtkObject *app_root)
>  {
> -  SpiApplication *retval = g_object_new (SPI_APPLICATION_TYPE, NULL);
> -
> -  spi_base_construct (SPI_BASE (retval), G_OBJECT(app_root));
> -
> -  return retval;
> +  return spi_accessible_construct (SPI_APPLICATION_TYPE, 
> +				   G_OBJECT (app_root));
>  }
> Index: libspi/base.h
> ===================================================================
> RCS file: /cvs/gnome/at-spi/libspi/base.h,v
> retrieving revision 1.3
> diff -u -p -u -r1.3 base.h
> --- libspi/base.h	18 Dec 2001 13:38:44 -0000	1.3
> +++ libspi/base.h	21 Mar 2002 11:43:06 -0000
> @@ -44,9 +44,9 @@ typedef struct {
>  
>  GType      spi_base_get_type          (void);
>  void       spi_base_construct         (SpiBase   *base,
> -				       GObject *gobject);
> +				       GObject   *gobject);
>  void       spi_base_construct_default (SpiBase   *base);
> -GObject *spi_base_get_gobject       (SpiBase   *base);
> +GObject   *spi_base_get_gobject       (SpiBase   *base);
>  
>  G_END_DECLS
>  
> 
> -- 
>  mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot
> 
> _______________________________________________
> Gnome-accessibility-devel mailing list
> Gnome-accessibility-devel gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel