Re: [g-a-devel]Commit permissions to at-spi ...

[Bill Haneman <bill haneman sun com>]

On Mon, 2002-08-12 at 15:34, Michael Meeks wrote:
> Guys,
> 
> 	More problem bodging going on in at-spi:
> 
> 	I being to dispair of this - not because of the code quality, but
> because of the lack of understanding and engagement from some Sun
> hackers; it seems the commit rules for at-spi go a bit like this:
> 
> 	if (Employee is Sun person) {
> 		Commit any old thing, without much approval / review
> 	} else {
> 		Person has no chance of committing anything, without 
> 		stringent review, and if person contributes 
> 		substantially has no chance of being a maintainer.
> 	}

Hi:

Not quite; but we conduct our floggings in private ;-)

I agree that this change should have been posted (I think it was, or
maybe it was just sent to me), reviewed, and approved first, like other
patches other than those from the official module maintainers (e.g. Marc
and I).  Honest mistakes are tolerated of course.

I think that it might be good for Marc and I to post our patches prior
to committing them also; I think Marc has done this in some cases
already.

-Bill

> 	This is just totally un-acceptable, I feel particularly agrieved having
> written such a big chunk of code, and sitting impotently by as other
> people commit stuff producing a progressively poorer result on top of
> it.
> 
> 	Can people _at least_ post their at-spi patches to the list, so there
> is at least some pretence of openness and review ?
> 
> 	Regards,
> 
> 		Michael.
> 
> Index: cspi/bonobo/cspi-bonobo-listener.c
> ===================================================================
> RCS file: /cvs/gnome/at-spi/cspi/bonobo/cspi-bonobo-listener.c,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -p -u -r1.13 -r1.14
> --- cspi/bonobo/cspi-bonobo-listener.c  19 Jun 2002 13:47:08 -0000      1.13
> +++ cspi/bonobo/cspi-bonobo-listener.c  12 Aug 2002 09:49:38 -0000      1.14
> @@ -91,7 +91,7 @@ cspi_event (SpiEventListener    *listene
>    GList *l;
>    CSpiEventListener *clistener = (CSpiEventListener *) listener;
>    AccessibleEvent    aevent;
> -  Accessible        *source = cspi_object_new (event->source);
> +  Accessible        *source = cspi_object_add (cspi_dup_ref(event->source));
>    
>    aevent.type    = event->type;
>    aevent.source  = source;
> @@ -105,6 +105,8 @@ cspi_event (SpiEventListener    *listene
>  
>        eh->cb.event (&aevent, eh->user_data);
>      }
> +
> +  cspi_object_unref( source );
>  }
>  
>  static void
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/at-spi/ChangeLog,v
> retrieving revision 1.232
> retrieving revision 1.233
> diff -u -p -u -r1.232 -r1.233
> --- ChangeLog   6 Aug 2002 14:55:31 -0000       1.232
> +++ ChangeLog   12 Aug 2002 09:49:38 -0000      1.233
> @@ -1,3 +1,13 @@
> +2002-08-12  Darren Kenny  <darren kenny sun com>
> +
> +       * cspi/bonobo/cspi-bonobo-listener.c: 
> +       (cspi_event):
> +       Don't call cspi_oject_new() because this is creating a new Accessible
> +       every single time that an event is fired. This causes ATs like at-poke
> +       to nolonger recognise the source of the event and thus ignore it.
> +       Re-use the object from the cache, ref it and then unref it after the
> +       listeners have been called.
> +
>  2002-08-06  Darren Kenny  <darren kenny sun com>
>  
>         * test/event-listener-test.c: 
> 
> -- 
>  mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot
> 
> _______________________________________________
> Gnome-accessibility-devel mailing list
> Gnome-accessibility-devel gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel