Re: xalf, glibc, stuff

[Frederic Crozat <fcrozat mandrakesoft com>]

On 12 Feb 2001 17:14:09 +0000, Telsa Gwynne wrote:
> So on #gnome-help today, someone was trying to get a newer xchat
> installed. And in the process, he required a newer glibc. He
> installed that and then "su broke, it complains about not finding
> a shared library". 
> 
> Pause for brief gibber :) 
> 
> We eventually figured it out. It was due to xalf inserting something
> into LD_PRELOAD and glibc not being entirely happy about that. We
> suggested he file a bug, and then we found someone had done precisely 
> that already: 
> 
> https://qa.mandrakesoft.com/dimension/cgi-bin/show_bug.cgi?id=2007


Yep, I found this bug just after we (at MandrakeSoft) provided glibc
update for setuid 
security break. Patch for xalf (I haven't yet send it to xalf author)
simply use path
for xalf libraries.

I've attach correcting patch (and I'm going to send it to xalf author
right now)


-- 
Frédéric Crozat
MandrakeSoft

--- xalf-0.4/lib/Makefile.am.preload	Thu Jun  1 16:28:45 2000
+++ xalf-0.4/lib/Makefile.am	Mon Jan 22 10:42:20 2001
@@ -6,6 +6,8 @@
 
 libxalflaunch_la_LDFLAGS = -version-info 0:1:0
 
+CFLAGS = -DLIBDIR=\""$(libdir)"\"
+
 ##INCLUDES = -I$(top_srcdir)/intl @GDK_IMLIB_CFLAGS@ @XML_CFLAGS@ @GNOME_CFLAGS@ @GTK_CFLAGS@ -DDIA_SHEETDIR=\"$(sheetdir)\"
 
 ## INCLUDES = @GTK_CFLAGS@
--- xalf-0.4/lib/xalflaunch.c.preload	Mon Jan 22 10:31:51 2001
+++ xalf-0.4/lib/xalflaunch.c	Mon Jan 22 10:42:54 2001
@@ -31,7 +31,7 @@
 
 
 #define PID_PROPERTY_NAME "XALF_LAUNCH_PID"
-#define PRELOAD_LIBRARY "libxalflaunch.so.0"
+#define PRELOAD_LIBRARY LIBDIR"/libxalflaunch.so.0"
 
 static void *pfXMapWindow = NULL;
 static void *pfXMapRaised = NULL;
--- xalf-0.4/src/Makefile.am.preload	Sun Jun 18 17:35:54 2000
+++ xalf-0.4/src/Makefile.am	Mon Jan 22 10:31:51 2001
@@ -11,7 +11,7 @@
 
 INCLUDES = @GTK_CFLAGS@ 
 
-CFLAGS = -Wall
+CFLAGS = -Wall -DLIBDIR=\""$(libdir)"\"
 
 
 EXTRA_DIST = hourglass.xpm splash.xpm hgcursor.h hgcursor_mask.h getopt.h \
--- xalf-0.4/src/xalf.c.preload	Sun Jun 18 17:26:03 2000
+++ xalf-0.4/src/xalf.c	Mon Jan 22 10:31:51 2001
@@ -63,7 +63,7 @@
 
 
 #define PID_PROPERTY_NAME "XALF_LAUNCH_PID"
-#define PRELOAD_LIBRARY "libxalflaunch.so.0"
+#define PRELOAD_LIBRARY LIBDIR"/libxalflaunch.so.0"
 #define USAGE "\
 Usage: %s [options] command\n\
 options:\n\