[Glade-devel] [glade-3] Problem with undo/redo menu getting too long

[damon karuna uklinux net (Damon Chaplin)]

Currently glade_command_set_property() does this:

        value_name = glade_property_class_make_string_from_gvalue
(property->class, pvalue);

         cmd->description = g_strdup_printf (_("Setting %s of %s to
%s"),
                                            property->class->name,
                                            gwidget->name,
                                            value_name);


Unfortunately value_name can be quite long, e.g. for flags or for string
properties. So the Undo/Redo menu items can become much too long.

I'd suggest passing a 'gboolean for_undo_menu' flag to
glade_property_class_make_string_from_gvalue(). For long properties like
flags and strings it would just return NULL. In that case the
description would be set like this (i.e. without the final 'to %s'):

         cmd->description = g_strdup_printf (_("Setting %s of %s"),
                                            property->class->name,
                                            gwidget->name);

Damon