[Glade-devel] [patch, glade3] fix assert on new window

[pborelli katamail com (paolo borelli)]

--=-dggKU4SiS4G8DIEnLW7Z
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi!

Every time I add a new toplevel window to a project I get the following
assert:

(glade-3:6729): Gtk-CRITICAL **: file gtkwindow.c: line 1905
(gtk_window_set_type_hint): assertion `!GTK_WIDGET_VISIBLE (window)'
failed

The attached patch seems to fix it... since I'm not really familiar with
the code in glade-command.c check carefully if it does not have bad side
effects.

ciao
        paolo

--=-dggKU4SiS4G8DIEnLW7Z
Content-Disposition: attachment; filename=fix-assert.patch
Content-Type: text/x-patch; name=fix-assert.patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

diff -upr gnome2/glade3/ChangeLog glade3/ChangeLog
--- gnome2/glade3/ChangeLog     2003-04-22 10:22:36.000000000 +0200
+++ glade3/ChangeLog    2003-04-22 14:26:36.000000000 +0200
@@ -1,3 +1,8 @@
+2003-04-22  Paolo Borelli <pborelli katamail com>
+
+       * src/glade-command.c: fix the assert you get each time you add a
+       new toplevel window.
+
 2003-04-21  Joaquin Cuenca Abela  <e98cuenc yahoo com>
 
        * src/glade-editor.c: fix a crash when you remove a item from a window.
diff -upr gnome2/glade3/src/glade-command.c glade3/src/glade-command.c
--- gnome2/glade3/src/glade-command.c   2003-03-09 21:37:46.000000000 +0100
+++ glade3/src/glade-command.c  2003-04-22 14:24:21.000000000 +0200
@@ -505,7 +505,6 @@ glade_command_create_execute (GladeComma
 
        if (GTK_IS_WIDGET (widget->widget)) {
                glade_project_selection_add (widget, TRUE);
-               gtk_widget_show (GTK_WIDGET (widget->widget));
        }
        
        return FALSE;


--=-dggKU4SiS4G8DIEnLW7Z--