Re: [gitg] Keep in sync

[nenopera <nenopera gmail com>]

Looking at git implementation, and saying it in plain words (reality is a little more complex), they do a walk through all commits and filter it due to flags provided. So Jesse, you are right, this one is not a for libgit, which have a more general scope.

Inside gitg, I suppose I must look into plugins/git-history.vala, Is there where gitg commits are retrieved? 

El 23/03/13 12:12, Jesse van den Kieboom escribió:

2013/3/23 nenopera <nenopera gmail com>

After my particular desert journey with jhbuild I'm finally in sync with the project. Let's see how far I get.

Just to remember, I want to implement the --simplify-by-decoration flag.

At same time (I think its a complement) add a check to every single branch to allow comparing branches of interest (Been more flexible than comparing one or all).

I guess for achieve that I must seek inside libgit, Am I right?

I'm not sure how much the libgit2 guys would like to implement special log filtering flags (like this one). For sure you should file a bug and talk to them first before working on the implementation. The other possibility is to do the filtering afterwards in gitg, which is probably easier to do/get accepted.

Jesse

 

El 17/03/13 11:25, Ignacio Casal Quinteiro escribió:

Suggestion, use jhbuild ;)

On Sun, Mar 17, 2013 at 11:07 AM, nenopera <nenopera gmail com> wrote:

Perfect.

I enabled it

$ ./autogen.sh --enable-introspection

then compile gitg and everything works.

...but

My OS started to fail. At first time didn't know what happen, but after a restart I was clear:

... You have an error ... depends on

/usr/local/lib/libpango...
/usr/local/lib/libglib...

So my approach to install the dependencies on /usr/local is not working, it corrupts the OS. I clean all and start over again

Please, Jesse any help about using jhbuild to build webkit2 I don't know where to post a similar question on webkit

I try

$ cd webkit-2.0
$ ./Tools/Scripts/update-webkit-libs-jhbuild --gtk
$ .Tools/Scripts/build-webkit --gtk

with no luck.

El 15/03/13 08:37, Ignacio Casal Quinteiro escribió:

Hey,

you need to enable webkit2 and introspection for webkit

On Fri, Mar 15, 2013 at 8:31 AM, nenopera <nenopera gmail com> wrote:

My fault. The old package gitg and its libraries was the trouble.

$ sudo apt-get remove gitg
$ sudo ldconfig # this for safety

and the gitg libraries compile smoothly.

Jeese, what are the steps to build webkit2 with jhbuild?. You mentioned it in your post to migrate to webkit2 https://mail.gnome.org/archives/gitg-list/2012-October/msg00016.html, but seems I forgot something

I just did:

$ svn checkout https://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.0
   ... after long time ...
$ cd webkit-20
$ ./autogen.sh

... download and compile all the dependencies, long, long time ...

$ make
    ... after a very long time ...
$ sudo make install

But I think my webkit2 compiling is not correct. When I do "make" on gitg project It says

make  all-recursive
make[1]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/gitg»
Making all in libgd
make[2]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/gitg/libgd»
make[2]: se sale del directorio «/home/alberto/projects/c/gitg-parent/gitg/libgd»
Making all in libgitg
make[2]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/gitg/libgitg»
make  all-am
make[3]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/gitg/libgitg»
make[3]: No se hace nada para «all-am».
make[3]: se sale del directorio «/home/alberto/projects/c/gitg-parent/gitg/libgitg»
make[2]: se sale del directorio «/home/alberto/projects/c/gitg-parent/gitg/libgitg»
Making all in libgitg-gtk
make[2]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/gitg/libgitg-gtk»
/usr/bin/g-ir-compiler  --includedir=. --includedir="../libgitg" -o GitgGtk-1.0.typelib GitgGtk-1.0.gir
../libgitg/Gitg-1.0.gir:10:51: warning: element annotation from state 6 is unknown, ignoring
../libgitg/Gitg-1.0.gir:11:54: warning: element annotation from state 6 is unknown, ignoring
Could not find GIR file 'WebKit2-3.0.gir'; check XDG_DATA_DIRS or use --includedir
error parsing file GitgGtk-1.0.gir: Failed to parse included gir WebKit2-3.0
make[2]: *** [GitgGtk-1.0.typelib] Error 1
make[2]: se sale del directorio «/home/alberto/projects/c/gitg-parent/gitg/libgitg-gtk»

make[1]: *** [all-recursive] Error 1

make[1]: se sale del directorio «/home/alberto/projects/c/gitg-parent/gitg»

make: *** [all] Error 2

I'm mainly interested in build with jhbuild, but don't know what steps to take. I try:

$ sudo apt-get install jhbuild
$ jhbuild bootstrap
$ cd webkit2
$ jhbuild --file Tools/gtk/jhbuildrc

but it not ends correctly. I know this is not a list about jhbuild or webkit, but any help wil be apreciatted.
 
El 14/03/13 10:11, Jesse van den Kieboom escribió:

Also, make sure to build libgit2 with THREAD_SAFE! If you do not, you'll get random crashes due to threading.

2013/3/14 Ignacio Casal Quinteiro <nacho resa gmail com>

Hey,

it builds perfectly here, so I suggest you to update libgit2 and libgit2-glib again. See that for libgit2 you need to build the "development" branch.

Cheers.

On Thu, Mar 14, 2013 at 9:03 AM, nenopera <nenopera gmail com> wrote:

I'm trying to keep in sync with new changes But after succesfully compile webkit2 and libgit2 I cannot compile libgit2-glib

$ cd libgit2-glib
$ ./autogen.sh
$ make
make  all-recursive
make[1]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/libgit2-glib»
Making all in libgit2-glib
make[2]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/libgit2-glib/libgit2-glib»
  GEN    ggit-enum-types.c
  GEN    ggit-enum-types.h
make  all-am
make[3]: se ingresa al directorio «/home/alberto/projects/c/gitg-parent/libgit2-glib/libgit2-glib»
  CC     ggit-enum-types.lo
  CC     ggit-blob.lo
  CC     ggit-branch.lo
ggit-branch.c: In function 'ggit_branch_delete':
ggit-branch.c:67:2: error: too few arguments to function 'git_branch_delete'
In file included from ggit-branch.c:24:0:
/usr/local/include/git2/branch.h:69:17: note: declared here
ggit-branch.c: In function 'ggit_branch_move':
ggit-branch.c:105:25: warning: passing argument 1 of 'git_branch_move' from incompatible pointer type [enabled by default]
In file included from ggit-branch.c:24:0:
/usr/local/include/git2/branch.h:114:17: note: expected 'struct git_repository *' but argument is of type 'struct git_reference **'
ggit-branch.c: In function 'ggit_branch_get_tracking':
ggit-branch.c:136:2: warning: implicit declaration of function 'git_branch_tracking' [-Wimplicit-function-declaration]
ggit-branch.c:136:2: warning: nested extern declaration of 'git_branch_tracking' [-Wnested-externs]
make[3]: *** [ggit-branch.lo] Error 1
make[3]: se sale del directorio «/home/alberto/projects/c/gitg-parent/libgit2-glib/libgit2-glib»
make[2]: *** [all] Error 2
make[2]: se sale del directorio «/home/alberto/projects/c/gitg-parent/libgit2-glib/libgit2-glib»
make[1]: *** [all-recursive] Error 1
make[1]: se sale del directorio «/home/alberto/projects/c/gitg-parent/libgit2-glib»
make: *** [all] Error 2

I can wait to have it working.

Ignacio I think I found an interesting task: Allow to show branchs with --simplified-by-decoration option. Is something I use to use more and more everyday.


_______________________________________________
gitg-list mailing list
gitg-list gnome org
https://mail.gnome.org/mailman/listinfo/gitg-list

--
Ignacio Casal Quinteiro

_______________________________________________
gitg-list mailing list
gitg-list gnome org
https://mail.gnome.org/mailman/listinfo/gitg-list

_______________________________________________
gitg-list mailing list
gitg-list gnome org
https://mail.gnome.org/mailman/listinfo/gitg-list

--
Ignacio Casal Quinteiro

_______________________________________________
gitg-list mailing list
gitg-list gnome org
https://mail.gnome.org/mailman/listinfo/gitg-list

--
Ignacio Casal Quinteiro

_______________________________________________
gitg-list mailing list
gitg-list gnome org
https://mail.gnome.org/mailman/listinfo/gitg-list