Re: [gitg] Pull requests

[Jesse van den Kieboom <jesse icecrew nl>]

On Sun, 26 Sep 2010 19:31:51 +0200, Guilhem Bonnefille
<guilhem bonnefille gmail com> wrote:
> Hi,
> 
> I come back again with this topic: pulling (some of) my topic branches.
> 
> As a reminder, here are the topic I worked on.
> 
> tab-for-changes with current content:
> * split details and diff in two tabs
> * add commiter details (name and date)
> * add clickable author and committer emails
> * add full commit's log with rendering features
>   ** title line in bold,
>   ** italic for Signed-off-by lines + clickable email of signer
> * improve performances: only refresh the tab displayed

I've been pressed for time and have not been able to really work on gitg
for some time. There have been some nice developments on master however.
For example, I've implemented the tab splits (loosely based on your work)
and added a sort of visual diff stat to the details of the commit view.
Also there is now per-line staging. The last thing I at least wanted to do
before a new release is better conflict resolution.

I greatly appreciate all your work and I'm sorry that I cannot seem to find
the time to review your work properly. If you agree, could you try out
latest master and see which patches are still relevant and easily
integrated?

> 
> three related branches:
> * refactor-spawning-feature: huge refactor to introduce GitgCommand
> object to wrap external commands

This I really want to push into master, but I will have to review it
carefully.

> * set-commit-author: adapt commit feature and UI to allow setting the
> author of a commit
> * select-commit-author: allow to select author of a commit from a list
> of already known authors

Same here, but should be more straightforward to pull in.

> 
> path-filtering: still in progress topic branch to allow to filter
> history content based on path
> I think it is just an experimental branch. A good solution should be
> to implement filter and search features in a more common way:
> * right-top textfield must allow to filter history view following
> different criteria (like evolution but based on author, path,
> title...)
> * Ctrl-F open a search field at the bottom of the UI, with prev/next
> buttons to iterate on search
> But things must still be done.

Searching has been on the TODO, but making it efficient is not trivial. I
would love to see it being improved though.

> 
> 
> As all these topics are quite old, they are merged with v0.0.5.
> I think some (or many?) of these patches are interesting. How can we
> integrate them to master? Should I merge/rebase them against v0.0.6 or
> with HEAD? Or should I convert them to topgit branches in order to
> package simple patches?

I would prefer if you could isolate the relevant parts and submit them to
bugzilla as one squashed commit per bug report, so that I can easily review
it with the bugzilla review tools. It's probably the easiest way to get
them pushed to master.

> 
> I really wan to see these patches applyed on gitg because I think they
> are usefull.
> 
> Best regards,