Re: [Gimp-developer] Big problem with Gimp G'MIC with upcoming Gimp 2.10

On Sun, 2014-04-27 at 12:05 +1200, Jehan Pagès wrote:

On Sun, Apr 27, 2014 at 4:55 AM, Jon Nordby <jononor gmail com> wrote:
One could set up g'mic or another well-maintained C++ plugin for GIMP
to build on Jenkins? That way these errors would be quickly (and
hopefully fixed).

Actually more simply a very simple do-nothing C++ plugin, yet which
includes all possible libgimp headers, could be integrated in the tree
as a C++ compilation test to be run during `make check`. That would
also catch these kind of bugs.

Done, we have such a file already:

commit a4773a559982dbf53a6f9b63c113452550e9e1ae
Author: Michael Natterer <mitch gimp org>
Date:   Sun Apr 27 14:30:00 2014 +0200

    plug-ins: include libgimp/gimp.h and gimpui.h in
    The file does not need the includes, but including libgimp from a C
    file makes sure the build fails if something forbidden gets added to
    any public libgimp header, such as a struct member named "private".

 plug-ins/file-exr/ | 8 ++++++++
 1 file changed, 8 insertions(+)

No need for anything more complicated like adding make check targets...


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]