Re: [gedit-list] Navigating to a file/line from the Shell Output

[Ignacio Casal Quinteiro <nacho resa gmail com>]

Hi, Thanks a lot for the patch.

Would you mind to open a bug and attach the patch there, so it is easier to review?

Regards.

On Tue, May 11, 2010 at 9:09 PM, Esko Luontola <esko luontola gmail com> wrote:

Here is the patch that I made. It will parse links from Go stack traces and GoSpec's test reports. I hope you will include it in the next release.

The regexp is quite generic and it produced some overlap with a couple of the other regexps, so I had to add a uniqueness check for the links. It might be better (for performance and clearer intention) to collect the links to a set, but that would require refactoring the existing tests, because they rely on the links to be reported in the same order as they are found.

This patch is based on GEDIT_2_30_2 because I was not able to compile the master branch on Ubuntu 10.04, but I think those files were not modified in master, so the patch should apply cleanly.

--
Esko Luontola
www.orfjackal.net

_______________________________________________
gedit-list mailing list
gedit-list gnome org
http://mail.gnome.org/mailman/listinfo/gedit-list