Re: [Geary] new ideas for the spam/junk icon in Geary

[Federico Bruni <fede inventati org>]

Il giorno mer 13 lug 2016 alle 15:04, Michael Gratton <mike vee net> ha scritto:

Hey Federico, On Wed, Jul 13, 2016 at 7:30 AM, Federico Bruni <fede inventati org> wrote:

I made a try, but as you see in the attached screenshot the inner part of the icon is turned into black by Geary. But it should darken only the colored parts and leave the transparent background as is, right? What I'm missing? Please try the attached patch.

Looking at the SVG, you'd need to do two things: Convert the triangle's stroke to a path, to fix the interior being black, and set the image size to be square (100x100 in this case), then position the icon so that it's vertically aligned. Otherwise, it all looks good. If you can update the patch with the fixed icon and attach it to Bug 737862, then I'll get it committed.

The strokes were already converted to a path.

The problem was that the triangle had fill:none while it should have fill:#ffffff, as explained here:

https://github.com/GNOME/gnome-icon-theme-symbolic

"""

There is a couple of things the icon author needs to be aware of and a few

things s/he can make use of. The stylesheet is setting the color of the fill

for all rectangles and paths. _DO_NOT_ leave any rectangles or paths with no

fill/stroke thinking it's invisible.

"""

However, while the background works fine now, the color of the triangle path remains light grey (i.e. the theme stylesheet is not applied to it). What is missing yet?

BTW, I found this icon:

https://git.gnome.org/browse/gnome-icon-theme-symbolic/tree/gnome/scalable/status/dialog-warning-symbolic.svg

but default size is 16x16px. It should be adapted, right?

Attachment: geary-new-spam-icon-2.png
Description: PNG image

Attachment: mail-junk-symbolic.svg
Description: image/svg