Re: [Geary] Crash on empty spelling suggestions

[Robert Schroll <rschroll gmail com>]

Nice one!  I've created a bug for it: 
https://bugzilla.gnome.org/show_bug.cgi?id=725518

I think you may be looking at the wrong WebKit function.  The one we 
want should return a WebKitContextMenuAction.  As best I can figure, 
this function doesn't properly account for this particular case, and it 
falls through to an assert_not_reached().

Thanks for finding this and getting us pointed in the right direction.

Robert


On Sun, Mar 2, 2014 at 8:03 AM, Mattias Eriksson <snaggen gmail com> 
wrote:
> Hi, 
>
> I seems that geary crashes when I click on a word that is misspelled 
> in the composer window but there is not suggestions available. 
> I have tracked it down to the following line in the 
> functionon_context_menu in the file composer-window.vala:
>             WebKit.ContextMenuAction action = 
> WebKit.context_menu_item_get_action(item);
>
> That function in webkit looks like
> GtkAction* webkit_context_menu_item_get_action(WebKitContextMenuItem* 
> item)
> {
>     g_return_val_if_fail(WEBKIT_IS_CONTEXT_MENU_ITEM(item), 0);
>
>     return item->priv->menuItem->gtkAction();
> }
>
> And from what I found it seems that item-> is non-null, so my guess 
> is that menuItem is null for some reason. 
>
> Now, I don't know vala and webkit well enough to know the root-cause 
> and find an easy fix for this. Hopefully you guys can fix this in a 
> heartbeat... 
>
> //Snaggen