Re: [gdm-list] Some GDM fixes for Solaris

["William Jon McCann" <mccann jhu edu>]

On 10/25/07, Brian Cameron <Brian Cameron sun com> wrote:
>
> I just built GDM from SVN head and had a few compile and runtime issues
> that are fixed in the attached patch.
>
> 1) The libnotification code would not compile because it couldn't find
>     the gtk header files.  Adding $(SIMPLE_GREETER_CFLAGS) made this
>     build okay.
>
> 2) The libnotification code and some test programs in the simple-greeter
>     directory wouldn't link because on Solaris you need to include the
>     $(SIMPLE_GREETER_LIBS) to get the glib/gtk symbols.

Should have been fixed already.

> 3) In simple-greeter/gdm-user-manager.c, the code now fails with
>     g_critical if it can't create the /etc/shells or /etc/passwd
>     monitors.  On Solaris, we don't have file monitoring support, so
>     this causes the greeter to just exit.  I think these should just
>     be warnings.  On systems that do not support file monitoring it
>     is annoying that GDM won't pick up these changes dynamically to
>     automatically update the face browser with new/removed users, but
>     it seems better to not just exit and leave the display with no
>     manager.

That's fine.  I've committed this part.

Thanks,
Jon