[PATCH]: small ui-fixes for gconf-editor



This patch...

* Expands the key and scroll it to the center of the view when opening
  a bookmark.

* Puts the value-list and the new scheme info in a GtkVPanned
 
* Makes the value input field little wider (50 chars) so you don't have 
  to scroll  the entry to see long strings.

	-Jens

? autom4te.cache
? gconf-editor-fixar.diff
? src/gconf-bookmarks.c.diff
? src/bookmarkscroll+editorsize.diff
? src/fixes.diff
? src/gconf-editor-workarounds.diff
Index: src/gconf-bookmarks.c
===================================================================
RCS file: /cvs/gnome/gconf-editor/src/gconf-bookmarks.c,v
retrieving revision 1.6
diff -u -u -r1.6 gconf-bookmarks.c
--- src/gconf-bookmarks.c	2002/02/11 03:51:02	1.6
+++ src/gconf-bookmarks.c	2002/05/22 21:49:48
@@ -62,8 +62,9 @@
 		gtk_tree_path_free (cpath);
 	}
 
+	gtk_tree_view_expand_row (GTK_TREE_VIEW (window->tree_view), path, FALSE);
 	gtk_tree_selection_select_path (gtk_tree_view_get_selection (GTK_TREE_VIEW (window->tree_view)), path);
-	gtk_tree_view_scroll_to_cell (GTK_TREE_VIEW (window->tree_view), path, NULL, 0, 0, 0);
+	gtk_tree_view_scroll_to_cell (GTK_TREE_VIEW (window->tree_view), path, NULL, 1, 0.5, 0.5);
 	gtk_tree_path_free (path);
 }
 
Index: src/gconf-editor-window.c
===================================================================
RCS file: /cvs/gnome/gconf-editor/src/gconf-editor-window.c,v
retrieving revision 1.27
diff -u -u -r1.27 gconf-editor-window.c
--- src/gconf-editor-window.c	2002/05/20 13:05:13	1.27
+++ src/gconf-editor-window.c	2002/05/22 21:49:48
@@ -35,6 +35,7 @@
 #include <gtk/gtkclipboard.h>
 #include <gtk/gtkframe.h>
 #include <gtk/gtkhpaned.h>
+#include <gtk/gtkvpaned.h>
 #include <gtk/gtkimage.h>
 #include <gtk/gtkitemfactory.h>
 #include <gtk/gtkmain.h>
@@ -579,14 +580,14 @@
 static void
 gconf_editor_window_init (GConfEditorWindow *window)
 {
-	GtkWidget *paned, *scrolled_window, *vbox;
+	GtkWidget *paned, *scrolled_window, *vbox, *vpaned;
 	GdkPixbuf *icon;
 	GtkTreeViewColumn *column;
 	GtkCellRenderer *cell;
 	GtkAccelGroup *accel_group;      
 	GtkItemFactory *item_factory;
 	GtkTreePath *path;
-	GtkWidget *details_frame, *pane_box, *table, *label, *text_view;
+	GtkWidget *details_frame, *table, *label, *text_view;
 	
 	/* Create popup menu */
 	window->popup_factory = gtk_item_factory_new (GTK_TYPE_MENU, "<main>", NULL);
@@ -732,13 +733,13 @@
 					GTK_POLICY_AUTOMATIC);
 	gtk_container_add (GTK_CONTAINER (scrolled_window), window->list_view);
 
-	pane_box = gtk_vbox_new (FALSE, 0);
-	gtk_box_pack_start (GTK_BOX (pane_box), scrolled_window, TRUE, TRUE, 0);
-	gtk_paned_add2 (GTK_PANED (paned), pane_box);
+	vpaned = gtk_vpaned_new ();
+        gtk_paned_pack1 (GTK_PANED (vpaned), scrolled_window, TRUE, TRUE);
+        gtk_paned_add2 (GTK_PANED (paned), vpaned);
 
 	/* Create details area */
 	details_frame = gtk_frame_new (_("Key Documentation"));
-	gtk_box_pack_start (GTK_BOX (pane_box), details_frame, FALSE, FALSE, 0);
+	gtk_paned_pack2 (GTK_PANED (vpaned), details_frame, FALSE, FALSE);
 
 	table = gtk_table_new (2, 4, FALSE);
 	gtk_table_set_row_spacings (GTK_TABLE (table), 4);
Index: src/gconf-key-editor.c
===================================================================
RCS file: /cvs/gnome/gconf-editor/src/gconf-key-editor.c,v
retrieving revision 1.10
diff -u -u -r1.10 gconf-key-editor.c
--- src/gconf-key-editor.c	2002/05/08 18:24:15	1.10
+++ src/gconf-key-editor.c	2002/05/22 21:49:48
@@ -205,6 +205,7 @@
 	value_box = gtk_hbox_new (FALSE, 0);
 	label = gtk_label_new_with_mnemonic (_("Key _value:"));
 	editor->string_widget = gtk_entry_new ();
+	gtk_entry_set_width_chars (GTK_ENTRY (editor->string_widget), 50);
 	gtk_entry_set_activates_default (GTK_ENTRY (editor->string_widget), TRUE);
 	gtk_label_set_mnemonic_widget (GTK_LABEL (label), editor->string_widget);	
 	gtk_box_pack_start (GTK_BOX (value_box), label, FALSE, FALSE, 0);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]