Re: Forcing enable-debug/enable-debug-minimal in garnome 2.19.1 using sed

[Yiannis Mavroukakis <yiannis jaguarfreight com>]

How about using the existing cookie infrastructure for this? 

On Thu, 2007-05-10 at 09:40 +0000, Peter wrote:
> This issue has been on my mind since 2.17, but now, I think the process 
> of forcing debug mode needs to be looked at.
> 
> In particular, these Makefiles use the construct
> 
> CONFIGURE_ARGS := $(shell echo $(CONFIGURE_ARGS) | sed 's,--disable-debug,--enable-debug,')
> or enable-debug-minimal.
> 
> which has the intent of forcing debug mode.
> 
> desktop/evolution/evo-data-server
> platform/glib (enable-debug-minimal)
> platform/gtk+ (enable-debug-minimal)
> platform/pango (enable-debug-minimal)
> 
> However, this logic is not correct, because in gar.gnome.mk, the
> following is used:
> 
> # For Unstable GARNOME, things are assumed to be heavily broken
> CONFIGURE_ARGS += --enable-debug --enable-tests
> CFLAGS += -g
> CXXFLAGS += -g
> 
> So, in all the above cases, these tests will fail, and instead of
> enable-debug-minimal, enable-debug will be used (for all but evo).
> 
> I really think this test should be removed. In fact, IMHO, the idea
> of using sed to hack a configure line is really superfluous.
> 
> In addition, there are some examples of sed removing --enable-debug
> and these occur in:
> 
> fifth-toe/gaim
> bootstrap/firefox
> 
> I think it makes more sense just to hard code the proper configure
> arguments.
> 
> Something to consider.
> 
> -- 
> Peter
> 

Note:__________________________________________________________________
This message is for the named person's use only. It may contain
confidential, proprietary or legally privileged information. No
confidentiality or privilege is waived or lost by any mistransmission.
If you receive this message in error, please immediately delete it and
all copies of it from your system, destroy any hard copies of it and
notify the sender. You must not, directly or indirectly, use, disclose,
distribute, print, or copy any part of this message if you are not the
intended recipient. Jaguar Freight Services and any of its subsidiaries
each reserve the right to monitor all e-mail communications through its
networks.
Any views expressed in this message are those of the individual sender,
except where the message states otherwise and the sender is authorized
to state them to be the views of any such entity.
________________________________________________________________________
This e-mail has been scanned for all known viruses.