Re: [Bug 403509] New: hal-kernel-includes patch does not apply cleany

[guenther <guenther rudersport de>]

On Mon, 2007-02-05 at 09:37 +0000, Yiannis Mavroukakis wrote:

> Sorry for the brevity I'll provide a little more detail.
> Slackware ships with a choice of two kernels 2.4.33.3 or 2.6.17.13.
> With 2.4.33.3 the headers are installed as part of the setup process.
> If the 2.6.17.13 kernel is chosen however, the headers need to be
> installed as a separate action after the setup has completed. So with
> this in mind, the user needs to be mindful to have installed the latest
> kernel headers (or symlink or whatever) to get hal to compile. 

Uhm, did I understand this correctly?  There are two possible reasons
for the patch to be necessary:  (a) no kernel headers installed or  
(b) 2.6 kernel installed with 2.4 kernel headers?


> However, there may be plenty of installs that don't grab the new headers
> so the patch is needed, and against the hal version included in
> 2.17.latest it fails. Granted, those who choose Slack as a distro are
> probably more experienced than most IMHO (no flames please...) and will
> take the necessary steps to fix the issue, but the lowest common
> denominator should also be catered for..

Maintaining custom patches should be done only, if they are necessary to
fix a broken build/tarball, or if they fix a serious bug.

IMHO, distro specific patches should go in only, if there is almost no
way for the user to fix the distro oops. In this case however, if I
understand you correctly, the "issue" simply is a matter of installing
the correct kernel headers -- which makes this nothing more than a
dependency outside of the GARNOME scope, that needs to be satisfied
(read installed) as provided by the distro.


If this is correct, I am going to remove the (broken) patch. Peter, Stef
and Ed confirmed it isn't necessary anyway. Thanks, dudes! :)

  guenther


-- 
char *t="\10pse\0r\0dtu\0  ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}