Re: GARNOME 0.23.0 is finally, at long last, really and truly OUT THERE!



bug 110842 is opened for this, the diff file is attached to the bug and
to this mail 

Let's hope people will read these mails before mailing again:)

Ron 

On Tue, 2003-04-15 at 12:53, Jeff Waugh wrote:
> <quote who="Ron Smits">
> 
> > I have encountered an error compiling sticky notes. The error occurs
> > because I am using gcc 2.95 instead of a gcc 3.x version.  there are
> > variable declarations between the code lines instead of at the beginning
> > of the function or compound block. 
> > 
> > You will need to change several lines to make it to work. I did a quick
> > fix for now, if people are interested I will post a diff. 
> 
> Please do, will be useful in the next version if there isn't an applets
> release.
> 
> > And yes Jeff before you verbally take my head of, I will check with
> > bugzilla and open a bug, so don't go mad on me
> 
> :-) When people send diffs, I generally check to see if they've been
> submitted upstream, and lodge the bugs if they haven't. But yeah, far far
> happier if you do them yourself. Thanks!
> 
> - Jeff
> 
> -- 
> GU4DEC: June 16th-18th in Dublin, Ireland             http://www.guadec.org/
>  
>                         Great minds think different?
--- /tmp/stickynotes_applet_callbacks.c	2003-04-15 13:02:51.000000000 +0200
+++ stickynotes_applet_callbacks.c	2003-04-15 13:04:09.000000000 +0200
@@ -168,12 +168,6 @@
 /* Menu Callback : Configure preferences */
 void menu_preferences_cb(BonoboUIComponent *uic, StickyNotesApplet *stickynotes, const gchar *verbname)
 {
-	if (stickynotes->prefs != NULL) {
-		gdk_window_raise(glade_xml_get_widget(stickynotes->prefs, "preferences_dialog")->window);
-		return;
-	}
-	
-	stickynotes->prefs = glade_xml_new(GLADE_PATH, "preferences_dialog", NULL);
 	GtkWidget *preferences_dialog = glade_xml_get_widget(stickynotes->prefs, "preferences_dialog");
 	
 	GtkAdjustment *width_adjust = gtk_spin_button_get_adjustment(GTK_SPIN_BUTTON(glade_xml_get_widget(stickynotes->prefs, "width_spin")));
@@ -181,6 +175,12 @@
 	GtkWidget *sticky_check = glade_xml_get_widget(stickynotes->prefs, "sticky_check");
 	GtkWidget *note_color = glade_xml_get_widget(stickynotes->prefs, "note_color");
 	GtkWidget *click_behavior_menu = glade_xml_get_widget(stickynotes->prefs, "click_behavior_menu");
+	if (stickynotes->prefs != NULL) {
+		gdk_window_raise(glade_xml_get_widget(stickynotes->prefs, "preferences_dialog")->window);
+		return;
+	}
+	
+	stickynotes->prefs = glade_xml_new(GLADE_PATH, "preferences_dialog", NULL);
 
 	{
 		GtkSizeGroup *size= gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
@@ -232,13 +232,13 @@
 /* Menu Callback : Display About window */
 void menu_about_cb(BonoboUIComponent *uic, StickyNotesApplet *stickynotes, const gchar *verbname)
 {
+	GtkWidget *about_dialog = glade_xml_get_widget(stickynotes->about, "about_dialog");
 	if (stickynotes->about != NULL) {
 		gdk_window_raise(glade_xml_get_widget(stickynotes->about, "about_dialog")->window);
 		return;
 	}
 	
 	stickynotes->about = glade_xml_new(GLADE_PATH, "about_dialog", NULL);
-	GtkWidget *about_dialog = glade_xml_get_widget(stickynotes->about, "about_dialog");
 
 	g_signal_connect(G_OBJECT(about_dialog), "response", G_CALLBACK(about_response_cb), stickynotes);
 

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]