Re: [gamin] gamin-fsset-control.patch
- From: John McCutchan <ttb tentacle dhs org>
- To: veillard redhat com
- Cc: gamin-list gnome org
- Subject: Re: [gamin] gamin-fsset-control.patch
- Date: Fri, 05 Aug 2005 14:31:47 -0400
On Fri, 2005-08-05 at 14:25 -0400, Daniel Veillard wrote:
> On Fri, Aug 05, 2005 at 02:10:55PM -0400, John McCutchan wrote:
> > Yo,
> >
> > Daniel, could you review this patch? It changes the code that decides
> > when to enable kernel monitoring / polling. It follows what we discussed
> > earlier: The exclude list has higher authority than the fsset code.
> >
> > I think it's correct, but it needs to be reviewed before it gets
> > committed.
>
> That looks correct. It may be nicer to factorize the 2 functions
> call to get more readable test conditions but it's cosmetic :-)
I know, it would be nice if these checks where factored into a nice set
of obvious operations. I will look into it.
--
John McCutchan <ttb tentacle dhs org>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]