Re: Investigating gnomine display corruption.

[rufus hamade <rufus myfanwy org uk>]

Hi Thomas,

I've created a bug, and also took this opportunity to do some minor updates to the fix.  It still uses a sucky mechanism for determining the background colour, but at least it isn't using c++ comments any more;->

Bug in question:
https://bugzilla.gnome.org/show_bug.cgi?id=640399

rufus

On Sun, Jan 23, 2011 at 9:13 PM, Thomas H.P. Andersen <phomes gmail com> wrote:

On Sat, Jan 22, 2011 at 13:14, rufus hamade <rufus myfanwy org uk> wrote:
> Hi All
>

> Here's a patch that fixes the background grid for iagno and reenables the
> "show grid" option.  It uses a somewhat dodgy mechanism for getting the
> background colour, but it works.  What we really need is a "pick color"
> method in gdk-pixbuf....
>
> Let me know if it isn't any good and/or if you want me to raise a bug in
> bugzilla to contain this patch.

it would be best to have the patch in a bug. It is easier to review
and discuss there.

Thanks for working on this :)

> rufus
>
> On Fri, Jan 21, 2011 at 6:51 AM, Thomas H.P. Andersen <phomes gmail com>
> wrote:
>>
>> On Thu, Jan 20, 2011 at 17:58, rufus hamade <rufus myfanwy org uk> wrote:
>> > Hi All,
>> >
>> > I've recently been playing around with tweaking gnomine to make it more
>> > interesting (for me at least.)
>> >
>> > Of course, gnomine is currently broken, so I've been doing some
>> > investigation into why that is the case.  My limited GTK/Cairo knowledge
>> > suggests the problem lies somewhere quite deep.
>> >
>> > Is anyone else looking at this issue?  I don't want to be stepping on
>> > any
>> > toes and/or duplicating work.  But I'd be happy to investigate myself,
>> > as
>> > this is a good way of improving my GTK knowledge.
>>
>> This would be very cool. Thanks.
>>
>> > Any hints before I start?
>>
>> The commit to port to gtk3/cairo is this one:
>>
>> http://git.gnome.org/browse/gnome-games/commit/?id=47f69c40286d7f7df86d0c61a585e0011a879c0f
>>
>> Also if you wish to there is another known bug graphics in iagno (my
>> fault). The grid is not drawn yet. The relevant commit for that is:
>>
>> http://git.gnome.org/browse/gnome-games/commit/?id=764c51939d8eb7eb647b76bbd9d28d2adc3a0726
>>
>> > Cheers,
>> >
>> > rufus
>> >
>> > _______________________________________________
>> > games-list mailing list
>> > games-list gnome org
>> > http://mail.gnome.org/mailman/listinfo/games-list
>> >
>> >
>
>