Re: glChess bug extermination

[Andreas Røsdal <andrearo pvv ntnu no>]

Hi Robert!

It's great that you managed to fix there tricky bugs! Here are some 
comments about the changes you made:

- The strings in glchess.in and gnome-sudoku.in will not be translated 
corrrectly. That is because the gettext textdomain is set in 
defaults.py.in in the respective games. You have introduced new 
string to glchess.in and gnome-sudoku.in, but the text domain isn't set 
until defaults.py.in is imported.

- Could you rewrite the new string so that the same translation can be 
used for both Sudoku and Chess? I'm referring to the text "Chess is not 
able to start because.....". You should use the APPNAME variable from 
defaults.py instead of hardcoding the game name, if possible. This means 
one new string, rather than two. It's always a good idea to reuse strings 
across games.

 - Andreas







On Tue, 23 Oct 2007, Robert Ancell wrote:

> The dialogs are now committed to svn...
>
> On 23/10/2007, Thomas H.P. Andersen <phomes gmail com> wrote:
> > The pop-up is a possibility, however we might end up showing this
> > dialog for problems not related to upgrading.
> >
> > [pie-in-the-sky]
> > Another idea for the future might be to listen for d-bus signals from
> > packagekit to check if the game (or a dependency) is being updated. I
> > took a quick glance at the documentation and it seems doable. It will
> > of course only be relevant if packagekit gets well adopted and might
> > be too much work to be worth it. It would be nice though to get rid of
> > all those upgrade related bug reports.
> > [/pie-in-the-sky]
> >
> > But the pop-up is a reasonable solution IMO.
> >
> > - Thomas
> >
> > On 10/23/07, Robert Ancell <robert ancell gmail com> wrote:
> > > Actually I've just confirmed two of the most duplicated bugs:
> > > http://bugzilla.gnome.org/show_bug.cgi?id=418427
> > > http://bugzilla.gnome.org/show_bug.cgi?id=412690