Re: frogr-list Digest, Vol 5, Issue 3

[Quinn Dombrowski <quinn quinndombrowski com>]

I just tried it out, and it works great now with auto-completion
turned off. Thanks for the fix!

~Quinn

On Sat, May 7, 2011 at 11:08 AM,  <frogr-list-request gnome org> wrote:
> Send frogr-list mailing list submissions to
>        frogr-list gnome org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>        http://mail.gnome.org/mailman/listinfo/frogr-list
> or, via email, send a message with subject or body 'help' to
>        frogr-list-request gnome org
>
> You can reach the person managing the list at
>        frogr-list-owner gnome org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of frogr-list digest..."
>
>
> Today's Topics:
>
>   1. Re: 0.5 beta feedback (Mario Sanchez Prada)
>   2. Re: 0.5 beta feedback (Mario Sanchez Prada)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sat, 07 May 2011 17:16:48 +0200
> From: Mario Sanchez Prada <msanchez igalia com>
> To: frogr-list gnome org
> Subject: Re: 0.5 beta feedback
> Message-ID: <1304781418.2162.26.camel@zoiberg>
> Content-Type: text/plain; charset="UTF-8"
>
> On Sat, 2011-05-07 at 09:23 -0500, Quinn Dombrowski wrote:
>> Hi Mario,
>>
>> I've been trying out the 0.5 beta, and the orientation for vertical
>> photos works great! So does the removing the file extension.
>
> Glad to hear that!
>
>> There's one pesky bug, though, that I've encountered. I've attached a
>> screenshot. When you double-click on an image to add tags and such,
>> this empty message comes up. I let it run for 5 minutes before I hit
>> cancel, and the tag editing window came up without a problem.
>
> Oopps! Yeah, it's actually a quite annoying bug I could reproduce easily
> here. Now working on that...
>
>> I think it has to do with me having tag completion turned off. When I
>> turned tag completion on, a message box came up (same size, shape, and
>> progress bar as the buggy un-message), but it didn't take long for
>> that box to go away and the tag editing window to come up.
>>
>> Also, when I have tag completion turned on, and I put a second photo
>> in Frogr and go to edit the tags, there's no message box that comes
>> up. However, when I turn off tag completion, the message box comes up
>> every time-- for the second photo, the same way as for the first.
>
> It seems it's all the same thing: looks like frogr tries to show the
> dialog because it is actually fetching tags in the background (no matter
> if the tags autocompletion feature is enabled or disabled) and showing
> the progress dialog when it shouldn't.
>
> Perhaps, I should make it so frogr didn't even try to fetch the tags
> list if the tags autocompletion feature is switched off, so we would be
> saving the extra network data transfer due to the list of tags. And if
> at some time you happen to enable the tags autocompletion feature, then
> frogr will at that moment download the list of tags.
>
> At the moment, I made it the other way around because I thought it
> wouldn't be a big deal to download the list of tags in the background
> anyway, but seeing that you cancelled the dialog after 5 minutes perhaps
> it is not worth it and it would be better not to download the tags when
> autocompletion is off.
>
> What do you think?
>
> Mario
>
>> Thanks again for all your work improving Frogr!
>
> Thanks for the awesome feedback.
>
> Mario
>
>
>
> ------------------------------
>
> Message: 2
> Date: Sat, 07 May 2011 18:07:43 +0200
> From: Mario Sanchez Prada <msanchez igalia com>
> To: frogr-list gnome org
> Subject: Re: 0.5 beta feedback
> Message-ID: <1304784472.2162.32.camel@zoiberg>
> Content-Type: text/plain; charset="utf-8"
>
> On Sat, 2011-05-07 at 17:16 +0200, Mario Sanchez Prada wrote:
>> [...]
>> It seems it's all the same thing: looks like frogr tries to show the
>> dialog because it is actually fetching tags in the background (no matter
>> if the tags autocompletion feature is enabled or disabled) and showing
>> the progress dialog when it shouldn't.
>
> I think I fixed these bugs now in master (and hopefully didn't introduce
> any new one), so I just created a couple of Ubuntu Maverick packages (32
> and 64 bit) for you to be able to test it easily (attached).
>
>> Perhaps, I should make it so frogr didn't even try to fetch the tags
>> list if the tags autocompletion feature is switched off, so we would be
>> saving the extra network data transfer due to the list of tags. And if
>> at some time you happen to enable the tags autocompletion feature, then
>> frogr will at that moment download the list of tags.
>
> I thought for a while about this and I definitely think it makes no
> sense to punish frogr uses having the tag autocompletion feature
> disabled by having to download anyway the full list of tags, even if
> they won't ever use it.
>
> So, I implemented it exactly that way: if tag autocompletion is disabled
> no tags will be fetched and if at some point that gets enabled, then
> right at that moment frogr will try to download the list of tags and
> will block (by showing a progress dialog with "Retrieving tags..."
> message) any attempt to open a dialog needing tags ("edit picture
> details" or "add tags" dialogs).
>
> Hope you like it and that it works better now.
>
> Thanks,
> Mario
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: frogr_0.5~unreleased-1maverick1_i386.deb
> Type: application/x-deb
> Size: 146910 bytes
> Desc: not available
> URL: <http://mail.gnome.org/archives/frogr-list/attachments/20110507/6aa513ff/attachment.bin>
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: frogr_0.5~unreleased-1maverick1_amd64.deb
> Type: application/x-deb
> Size: 153872 bytes
> Desc: not available
> URL: <http://mail.gnome.org/archives/frogr-list/attachments/20110507/6aa513ff/attachment-0001.bin>
>
> ------------------------------
>
> _______________________________________________
> frogr-list mailing list
> frogr-list gnome org
> http://mail.gnome.org/mailman/listinfo/frogr-list
>
>
> End of frogr-list Digest, Vol 5, Issue 3
> ****************************************
>