Re: ufraw (and others) integration

["Tim Thomson" <tim thomson gmail com>]

I just discovered svn diff, lots easier than diff -u.

The attached diff simply adds Pentax RAW file extensions to the list
in the IsRaw function.

I'm had a slow time compiling and installing the DevelopInUFraw
extension. Will have another go tonight. Hopefully have another small
diff by tomorrow.

Are these ok posted to the list, or should I open bug reports for tiny
things like this?

Cheers,

Tim.



On 10/23/07, Stephane Delcroix <stephane delcroix org> wrote:
> Nice sugestions. Patches are welcome...
>
> s
>
>
> On Mon, 2007-10-22 at 22:36 +1000, Tim Thomson wrote:
> > Hi everyone,
> >
> > I'm liking the way things are going with RAW processing recently, I
> > think I might be about to make a full switch back from digikam.
> >
> > Just a couple of issues I've noticed, Pentax's .pef and .dng
> > extensions aren't in the IsRaw function so it won't shell out to
> > ufraw. (src/Imaging/ImageFile.cs line 218). I'm guessing there are
> > probably a few other ufraw supported RAW filetypes missing?
> >
> > Also, I think raw.Uri should be escaped when shelling out to ufraw so
> > that if a picture name has special characters, or someone opts to not
> > copy files when importing the call to ufraw will still work.
> > (extensions/DevelopInUFraw/DevelopInUFRaw.cs, line 35 perhaps?)
> >
> > The PEF RAW thumbnails are not displayed in the main browser, though
> > the DNG files are. From a quick look at the source it looks like this
> > is handled by the gnome libs, so I guess once I upgrade gnome it might
> > start working? It's interesting that they work fine in nautilus
> > though...
> >
> > It'd be nice to have f-spot not block when calling ufraw with this
> > extension, so you could still look at your other photos while
> > developing to compare, but I guess that would be pretty tricky
> > currently.
> >
> > Cheers,
> >
> > Tim.
> > _______________________________________________
> > F-spot-list mailing list
> > F-spot-list gnome org
> > http://mail.gnome.org/mailman/listinfo/f-spot-list
> >
>
>

Index: src/Imaging/ImageFile.cs
===================================================================
--- src/Imaging/ImageFile.cs	(revision 3434)
+++ src/Imaging/ImageFile.cs	(working copy)
@@ -215,7 +215,7 @@
 
 		public static bool IsRaw (string name)
 		{
-			string [] raw_extensions = {".nef", ".crw", ".cr2", ".arw", ".mrw"};
+			string [] raw_extensions = {".nef", ".crw", ".cr2", ".arw", ".mrw", ".pef", ".dng"};
 			foreach (string ext in raw_extensions)
 				if (ext == System.IO.Path.GetExtension (name).ToLower ())
 					return true;