On Sun, 2006-10-01 at 01:19 +0300, Dotan Cohen wrote: > On 17/09/06, Dotan Cohen <dotancohen gmail com> wrote: > > On 17/09/06, Bengt Thuree <bengt thuree com> wrote: > > > Hi Guys, > > > > > > I created a new small bug #356387 [1] with patch [2] for the following > > > problem. .. > > > It imports the tags in Dotans test photos nicely, apart from the headline since F-Spot do not import any headline for the moment. > > > My iViewMedia Pro test photos gets duplicated XMP tags (People, Location, etc) due to they already existed. .. > > > [1] : http://bugzilla.gnome.org/show_bug.cgi?id=356387 > > > [2] : http://bugzilla.gnome.org/attachment.cgi?id=72935&action=view > > > [3] : http://bugzilla.gnome.org/show_bug.cgi?id=356330 > > > > > > > Bengt, > I finally compiled and ran this patch- it works great. All our data > was imported. However, the tags are not converted to XMP even though I > have the appropriate option checked in the Preferences. So I figured > that if I drag and drop the tags to new top-level tags, the > information would be re-written as XMP data, but not so. What can I do > to have F-Spot convert the data to XMP? Because I'm not certain that > this patch will continue working on future versions of F-Spot, and I'd > like to have all my data in one format (ie, XMP). Hi Dotan, That was great news, sorry that it took me some time to figure out what to do to fix it for you. You say they are not stored in XMP. Which tags? All of them or only the headlines? I tried to add a new tag to the test photo (åäöÅÄÖ) and then re-import this photo to F-Spot, and the tags appeared nicely. Larry has disabled the headline for a while, if you want to re-enable that one do modify the XmpTagsImporter.cs as below: > switch (stmt.Predicate.Uri) { > case Description: > - case Headline: > +// case Headline: > case Caption: > case Title: > case UserComment: > @@ -152,6 +153,12 @@ namespace FSpot.Xmp { > list.Add (stmt); > break; > > + case Headline: > + Literal l = stmt.Object as Literal; > + if (l != null && l.Value != null && l.Value.Length > 0) > + photo.Description = l.Value; > + break; > + -Bengt
Attachment:
signature.asc
Description: This is a digitally signed message part