30+ patches in BugZilla.

["Bengt Thuree" <bengt thuree com>]

Hi

I went through some of the F-Spot bugs with an attached patch, and I am
not to happy with the result to be honest. Some of the patches have been
there for almost 16 months, a few around 12 months, and quite a lot around
5 months. This is time with more or less no comments and feedback. No
indication if the patch should be accepted, or what the problem is with
the patch for it to be accepted.
I can imagine a lot of people out there happily creating a patch, and then
no response at all, or some good comments in BugZilla, but the patch do
not appear in F-Spot at all. A lot of these people will likely not send in
another patch unfortunately.

I see some comments that the patch is not solving it to 100% or is just a
workaround for a fault in another product. But the fact that there is a
bug in BugZilla indicates that there is a problem, and a possible patch
fixes it (hopefully). If it is not perfect, lets include it to HEAD, and
fix it over time (new bug reports). If it is not F-Spot's fault, lets
include it for now, perhaps with a CONFIGURE directive that will disable
this when the other product are fixed.

HEAD should not always be perfect. The relased stable versions should be
more reliable. Or?

Below are some of the bugs with associated patch. In no other order than I
found them.
Some of them seems to be very very simple, and should have no problem to
be accepted.
Some of them are much more complicated and more thorough check and test
would be appropriate.
All of them deserves more feedback though. And if the patch is
unaccaptable, please state that. If nothing else we also need to keep the
amount of bugs down (by fixing the fault hopefully :) )

/Bengt


Bug 139796 ? selecting multiple tags should limit query (use AND not OR)
http://bugzilla.gnome.org/show_bug.cgi?id=139796
Patch added 2006-01-20 (Query branch)

Bug 153023 ? [PATCH] Preview image showed when changed workspace
http://bugzilla.gnome.org/show_bug.cgi?id=153023
Patch added 2005-01-27

Bug 301151 ? Please add keyboard shortcut for deleting images from disk
http://bugzilla.gnome.org/show_bug.cgi?id=301151
Patch added 2006-05-12

Bug 318931 ? [PATCH]SlideView: Working keys & Jump to last image on exit
http://bugzilla.gnome.org/show_bug.cgi?id=318931
Patch added 2006-02-22

Bug 321928 ? Pre-defined date ranges
http://bugzilla.gnome.org/show_bug.cgi?id=321928
Patch added 2005-12-24

Bug 332584 ? Inconsistency in displayed tag icons
http://bugzilla.gnome.org/show_bug.cgi?id=332584
Patch added 2006-04-06

Bug 338842 ? gets seriously confused in full-screen mode, leading to
deletion of the wrong photos/data-loss
http://bugzilla.gnome.org/show_bug.cgi?id=338842
Patch added 2006-05-15

Bug 302566 ? [PATCH] posibility of batch resize/rename of pics
http://bugzilla.gnome.org/show_bug.cgi?id=302566
Patch added 2006-02-04

Bug 321770 ? Auto Tag imported photos with special tag
http://bugzilla.gnome.org/show_bug.cgi?id=321770
Patch added 2006-01-27

Bug 328245 ? Give versions better default names
http://bugzilla.gnome.org/show_bug.cgi?id=328245
Patch added 2006-02-16

Bug 329581 ? Added 3.5 and 8.5 constraints to Crop
http://bugzilla.gnome.org/show_bug.cgi?id=329581
Patch added 2006-02-02

Bug 339081 ? lossless JPEG-cropping
http://bugzilla.gnome.org/show_bug.cgi?id=339081
Patch added 2006-06-15

Bug 152506 ? relocation error in libfspotjpegtran
http://bugzilla.gnome.org/show_bug.cgi?id=152506
Patch added 2005-01-30

Bug 165645 ? Rotate image when exporting
http://bugzilla.gnome.org/show_bug.cgi?id=165645
Patch added 2006-04-18

Bug 169646 ? need to handle duplicates
http://bugzilla.gnome.org/show_bug.cgi?id=169646
Patch added 2006-03-28

Bug 300984 ? Import from Gallery Installs
http://bugzilla.gnome.org/show_bug.cgi?id=300984
Patch added 2006-03-28

Bug 314559 ? Be able to scale pictures when sending an e-mail
http://bugzilla.gnome.org/show_bug.cgi?id=314559
Patch added 2005-08-26

Bug 322349 ? Missing tooltips in various places
http://bugzilla.gnome.org/show_bug.cgi?id=322349
Patch added 2005-12-02

Bug 322366 ? Import existing data from gthumb
http://bugzilla.gnome.org/show_bug.cgi?id=322366
Patch added 2006-02-24

Bug 323237 ? several HIG fixes for f-spot dialogs
http://bugzilla.gnome.org/show_bug.cgi?id=323237
Patch added 2006-02-28

Bug 325165 ? Slideshow config options
http://bugzilla.gnome.org/show_bug.cgi?id=325165
Patch added 2006-05-12

Bug 329685 ? Add Meta Tags to HTML export for encoding, etc
http://bugzilla.gnome.org/show_bug.cgi?id=329685
Patch added 2006-03-27

Bug 329841 ? Day directory without leading 0 (1-31 instead of 01-31)
http://bugzilla.gnome.org/show_bug.cgi?id=329841
Patch added 2006-03-06

Bug 331503 ? Importing photos do not keep the unix time stamp
http://bugzilla.gnome.org/show_bug.cgi?id=331503
Patch added 2006-02-17

Bug 331953 ? Global configuration file /etc/f-spot
http://bugzilla.gnome.org/show_bug.cgi?id=331953
Patch added 2006-03-02

Bug 335935 ? Export to folder bugs when pictures bear same name
http://bugzilla.gnome.org/show_bug.cgi?id=335935
Patch added 2006-03-27

Bug 336178 ? Export to folder should also export tags
http://bugzilla.gnome.org/show_bug.cgi?id=336178
Patch added 2006-03-27

Bug 337724 ? WorkerThread + Database threading.
http://bugzilla.gnome.org/show_bug.cgi?id=337724
Patch added 2006-05-13

Bug 340239 ? F-spot libraries do not link to all dependencies
http://bugzilla.gnome.org/show_bug.cgi?id=340239
Patch added 2006-05-01

Bug 340497 ? Export to Gallery Add album crash
http://bugzilla.gnome.org/show_bug.cgi?id=340497
Patch added 2006-05-04

Bug 321025 ? Smaller Tag Views/Icons
http://bugzilla.gnome.org/show_bug.cgi?id=321025
Patch added 2006-02-22

Bug 337347 ? Favorites tag is still a tag, not a category
http://bugzilla.gnome.org/show_bug.cgi?id=337347
Patch added 2006-04-06

Bug 339554 ? Tag Icon not changed when spin button changes in Tag Icon Editor
http://bugzilla.gnome.org/show_bug.cgi?id=339554
Patch added 2006-04-24

Bug 340507 ? f-spot crashed when adding tag to offline image (thumbnail)
http://bugzilla.gnome.org/show_bug.cgi?id=339554
Patch added 2006-04-24





-- 
Bengt Thuree   bengt thuree com