Re: Patch Review please : 321770 - Import Roll History

["Marcus Hast" <marcushast gmail com>]

> There are actually two bugs in bugzilla
>
> http://bugzilla.gnome.org/show_bug.cgi?id=321770 -> Keeping
> track of the last 20 import rolls
>  http://bugzilla.gnome.org/show_bug.cgi?id=342482 -> Store
> import datetime with the photo
>
> Some time ago, a concensus was made that it was enough to only track the
> latest 20 (or so) import rolls. ...
> Personally I think it should be enough with only keeping track of the latest
> 20 rolls or so, so you can tagg them nicely (means you have some time to
> tagg each roll). If enough arguments states we should keep the import time
> permanently, then I can change to the other solution.

Ok that explains it. I was at first considering that there may be some
performance issues with doing putting the import time in the photos.
To me it seems like the code would be cleaner that way. And with a
more powerful search you could do some queries involving rolls as
well.

And as I wrote previously I think that being able to group images per
"import roll" is a pretty natural way of doing it. It is also
something which the other photo management programs does so supporting
it could be a good way of easing people over. My biggest worry with
having an arbitrary (and predefined) limit to how many rolls you
remember is that someday you'll end up importing more than the magical
limit and then you'll be really annoyed.

Personally I would like to see more grouping capabilities in F-Spot
and it seems like import rolls are only a special case of that. I
still haven't gotten around to start coding just yet (I'm mainly
browsing the code at this stage) but it's definately something I'd
consider working on.

/Marcus