Fwd: Patch Review please : 321770 - Import Roll History

["Bengt Thuree" <bengt thuree com>]

Sorry, missed sending this to the list

/Bengt

---------- Forwarded message ----------
From: Bengt Thuree <bengt thuree com
>
Date: Aug 17, 2006 8:58 AM
Subject: Re: Patch Review please : 321770 - Import Roll History
To: Marcus Hast <marcushast gmail com>

Hi

There are actually two bugs in bugzilla

http://bugzilla.gnome.org/show_bug.cgi?id=321770 -> Keeping track of the last 20 import rolls
http://bugzilla.gnome.org/show_bug.cgi?id=342482 -> Store import datetime with the photo

Some time ago, a concensus was made that it was enough to only track the latest 20 (or so) import rolls. Therefore, I mainly worked on the 321770 patch, and stopped working on 342482.

The latest patch in 321770 keeps the number of rolls to keep track of in GConf, so you can set it to  the last 100 rolls or so.  (Do not work to good with the gui though)

Personally I think it should be enough with only keeping track of the latest 20 rolls or so, so you can tagg them nicely (means you have some time to tagg each roll). If enough arguments states we should keep the import time permanently, then I can change to the other solution.

/Bengt

On 8/17/06, Marcus Hast < marcushast gmail com> wrote:

Hi all,
Sorry to begin talking about this several weeks after the fact. But I
do have some questions regarding this patch.

On 8/3/06, Bengt Thuree < bengt thuree com> wrote:
> Hi Guys
>
> New patch submitted for bug 321770 - Keeping track of the last 20 import
> rolls.


Or only one really: Is the information regarding which import roll a
photo "belongs to" deleted from the database? It seems to me that this
would be unfortunate.

Perhaps I've gotten too used to how I organise my photos but I prefer
to have my photos primarily organised by "rolls of film", which would
correspond to the import rolls.

It also seem to me that if the "import roll" field was simply a
timestamp for the roll import it would be easy to get the last X
import rolls. (Where X is any number determined by the user at the
time running the search.) At least I imagine it would be easy with my
very limited SQL experience, but organising the import_roll values in
reverse chronological order and then selecting the first X should be
quite simple, or am I missing something? (It's quite possible as I
have no experience coding against SQL servers.)

Furthermore it might be good to keep the import roll timestamp around
for future uses. Personally I like to view my images grouped by import
rolls, but that's probably mainly because of how I organise my images
in addition to my previous use of Picasa.

So, to reiterate, is the import roll info saved per photo or in a
separate database table?

Regards,
Marcus Hast
_______________________________________________
F-spot-list mailing list
F-spot-list gnome org
http://mail.gnome.org/mailman/listinfo/f-spot-list