Re: Tag typing.

[Aaron Bockover <abockover novell com>]

Here's a slightly better version.
--Aaron

On Thu, 2005-11-10 at 01:18 -0500, Aaron Bockover wrote:
> Attached is a simple patch to enable this functionality. I haven't
> thoroughly tested it, but it gives the intended behavior, if anyone
> wants to see what it "feels" like. Apply against version 3 of the
> type-to-tag patch.
> 
> --Aaron
> 
> On Thu, 2005-11-10 at 00:52 -0500, Nat Friedman wrote:
> > On Thu, 2005-11-10 at 00:48 -0500, Aaron Bockover wrote:
> > 
> > > Pressing enter if there is a selection (i.e. a tag that was matched and
> > > can be expanded) should expand the tag... append a space after the
> > > selection and move the cursor to the end of the selection/expanded tab,
> > > ready to input a second tag. If there is no selection in the entry, the
> > > enter key applies the tag(s). If there is a selection, the enter key
> > > places the cursor at the end of the selection.
> > 
> > This actually seems like a pretty good idea.  I was hoping not to have a
> > version 4 of this patch before hitting CVS but this idea seems like it's
> > worth trying.  But I'm going to wait to see what other people say about
> > the selection/completion first.
> > 
> > Nat
> > 
> > 
> _______________________________________________
> F-spot-list mailing list
> F-spot-list gnome org
> http://mail.gnome.org/mailman/listinfo/f-spot-list

--- MainWindow.cs.orig	2005-11-10 01:15:23.000000000 -0500
+++ MainWindow.cs	2005-11-10 01:30:08.000000000 -0500
@@ -2144,7 +2144,16 @@
 
 		if (selected_photos == null || tagnames == null)
 			return;
-		
+
+		int sel_start, sel_end;
+		if (tag_entry.GetSelectionBounds (out sel_start, out sel_end)) {
+			tag_entry.InsertText (", ", ref sel_end);
+			tag_entry.SelectRegion (-1, -1);
+			tag_entry.Position = sel_end + 2;
+			ClearTagCompletions ();
+			return;
+		}
+
 		// Add any new tags to the selected photos
 		Category default_category = null;
 		Tag [] selection = tag_selection_widget.TagHighlight ();