Re: [evolution-patches] Warning fixes

[Matthew Barnes <mbarnes redhat com>]

On Thu, 2006-09-21 at 02:04 -0400, Pavel Roskin wrote:
> This patch fixes certain classes of warnings across the board:
> 
> - Function declared static but never defined
> - No previous prototype
> - Initialization makes integer from pointer without a cast
> - Passing argument makes pointer from integer without a cast

The patch looks good to me.  The only minor nit I have is in
message-list.c where you add a cast to the last argument:

g_object_set_data (((GnomeCanvasItem *) item)->canvas, "freeze-cursor",
(gpointer) 1);

I'd prefer to see GINT_TO_POINTER (1).


> Similar warnings may indicate problems on 64-bit systems.  It's
> important to eliminate the easy stuff to make new warnings of this kind
> very visible.

Absolutely.  You're efforts are appreciated.


Matthew Barnes