Re: [evolution-patches] Memory improvement for the tokens in camel_folder_summary.c
- From: "Veerapuram Varadhan" <vvaradhan novell com>
- To: <spam pvanhoof be>
- Cc: evolution-patches gnome org
- Subject: Re: [evolution-patches] Memory improvement for the tokens in camel_folder_summary.c
- Date: Wed, 26 Jul 2006 08:03:10 -0600
On Wed, 2006-07-26 at 12:35 +0000, Philip Van Hoof wrote:
> +
> +guint bytes;
Whats this for? Didn't you get a warning of "unused variable"?
> +
> + for (i=0; i<tokens_len; i++)
> + if (!strcmp (str, tokens[i]))
> + {
should be...
if (!strcmp(str, tokens[i])) {
No need to resend another patch. I will take it in this time, however,
do take care of coding style in your future patches.
V. Varadhan
Novell, Inc.
Software for the Open Enterprise™
http://www.novell.com
[
Date Prev][
Date Next] [
Thread Prev][Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]