Re: [evolution-patches] Memory improvement for the tokens in camel_folder_summary.c

[Philip Van Hoof <spam pvanhoof be>]

On Wed, 2006-07-26 at 08:03 -0600, Veerapuram Varadhan wrote:
> On Wed, 2006-07-26 at 12:35 +0000, Philip Van Hoof wrote:

> > +guint bytes;
> Whats this for?  Didn't you get a warning of "unused variable"?

Yep. It can be removed

> > +       for (i=0; i<tokens_len; i++)
> > +               if (!strcmp (str, tokens[i]))
> > +               {
> should be...
>                   if (!strcmp(str, tokens[i])) {

ok.

> No need to resend another patch.  I will take it in this time, however,
> do take care of coding style in your future patches.

Right. Sorry for that. I have this funny "{" on-a-newline style
myself ;-)


-- 
Philip Van Hoof, software developer at x-tend 
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
work: vanhoof at x-tend dot be 
http://www.pvanhoof.be - http://www.x-tend.be