Re: [evolution-patches] Re: default-mailer patch

[Not Zed <notzed ximian com>]

Jonathan,

I'm pretty happy with this, but to finally accept it we'll need the copyright assigned.

See here:

http://forge.novell.com/modules/xoopsfaq/?cat_id=30#q61

Thanks,
 Michael

On Thu, 2005-03-24 at 16:34 +0200, Jonathan Dieter wrote:
> Okay, I've removed the 'ask default' option, and created a gconf 
> schema.  I also prefixed all public symbols with 
> org_gnome_default_mailer, though after removing the 'ask default' 
> option, the only public symbol left was the check_default() function.  
> Let me know if there's anything else you think should be changed.
>
> Not Zed wrote:
>
> >
> >
> > Looks prety good at a first glance.
> >
> > I don't think we realy need the 'ask default' option in the mail 
> > configuratin window though.  To me it just seems like clutter for an 
> > option very few people, if anyone, would ever want to reset.  If they 
> > do, there's always gconf-editor, assuming the key is properly 
> > documented - you should add a gconf schemas file for this purpose 
> > (although to be honest i don't know how you do that off the top of my 
> > head).
> >
> > You should probably also prefix the public symbol names with the 
> > org_gnome_xxxx stuff, to avoid name clashes (these will become public 
> > symbols in the whole evolution application).  (i..e the callbacks).
> >
> > Thanks,
> > Michael
> >